Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-4.15] USHIFT-2208: add periodic test scenario for the standard tests on rpm-based system #2914

Merged
merged 3 commits into from
Feb 21, 2024
Merged

[release-4.15] USHIFT-2208: add periodic test scenario for the standard tests on rpm-based system #2914

merged 3 commits into from
Feb 21, 2024

Conversation

dhellmann
Copy link
Contributor

Manual backport of #2850

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 22, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 22, 2024 •
edited by openshift-ci bot

@dhellmann: This pull request references USHIFT-2208 which is a valid jira issue.

In response to this:

Manual backport of #2850

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jan 22, 2024
@dhellmann
Copy link
Contributor Author

Updated to include part of #2746 from @eggfoobar

@dhellmann dhellmann force-pushed the USHIFT-2208-periodic-rpm-standard-415 branch from 422228d to e19f0fc Compare January 22, 2024 17:06
@dhellmann
Copy link
Contributor Author

We will need to backport #2918 before we can merge this change.

dhellmann and others added 3 commits January 24, 2024 10:02
@dhellmann
simplify selinux fcontext test
fecca99 
Instead of trying to build a full set of the rules we think should be
present, just ensure that we see the ones that MicroShift adds. The
others may change outside of our control, and may be different on
RPM-based on ostree-based systems.
@dhellmann
USHIFT-1848: add periodic test scenario for the standard tests on rpm…
24e9a32 
…-based system
@zpytela @dhellmann
selinux: minor fixup
15fb16a
@dhellmann dhellmann force-pushed the USHIFT-2208-periodic-rpm-standard-415 branch from e19f0fc to 15fb16a Compare January 24, 2024 15:02
@dhellmann
Copy link
Contributor Author

The ARM job failed with an unrelated issue in the storage snapshot test. https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/test-platform-results/pr-logs/pull/openshift_microshift/2914/pull-ci-openshift-microshift-release-4.15-microshift-metal-tests-arm/1750172324713205760/artifacts/microshift-metal-tests-arm/openshift-microshift-e2e-metal-tests/artifacts/scenario-info/el92-src@storage/log.html

@dhellmann
Copy link
Contributor Author

/override ci/prow/microshift-metal-tests-arm
/label backport-risk-assessed

@openshift-ci openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jan 24, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 24, 2024

@dhellmann: Overrode contexts on behalf of dhellmann: ci/prow/microshift-metal-tests-arm

In response to this:

/override ci/prow/microshift-metal-tests-arm
/label backport-risk-assessed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor

/label jira/valid-bug
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 25, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor

/label jira/valid-bug

@openshift-ci openshift-ci bot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jan 26, 2024
@pacevedom
Copy link
Contributor

/label cherry-pick-approved

pacevedom
pacevedom reviewed Jan 30, 2024
View reviewed changes
Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label cherry-pick-approved
/hold
Just in case QE wants to test it out as there were changes in selinux. Feel free to remove it.

@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. labels Jan 30, 2024
@agullon
Copy link
Contributor

agullon commented Feb 19, 2024 •
edited

hi @pacevedom I'd like to get this PR merged. Also created another PR to merge this changes into release-4-14 branch: #3046

@dhellmann
Copy link
Contributor Author

dhellmann commented Feb 19, 2024 •
edited

/label staff-eng-approved

@agullon I've added the missing label. I'll leave it up to you and @pacevedom to remove the hold when you're comfortable landing a CI change.

@openshift-ci openshift-ci bot added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Feb 19, 2024
@pacevedom
Copy link
Contributor

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 21, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 0a94ba2 and 2 for PR HEAD 15fb16a in total

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 21, 2024

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit bb96b72 into openshift:release-4.15 Feb 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pacevedom pacevedom pacevedom left review comments

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@jogeo jogeo Awaiting requested review from jogeo

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@dhellmann @openshift-ci-robot @ggiguash @pacevedom @agullon @zpytela