USHIFT-2214: Add missing dependency of microshift-olm on microshift package #2924
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request references USHIFT-2214 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
packaging/rpm/microshift.spec
Outdated
| @@ -410,6 +411,9 @@ systemctl enable --now --quiet openvswitch || true | |||
| # Use Git command to generate the log and replace the VERSION string | |||
| # LANG=C git log --date="format:%a %b %d %Y" --pretty="tformat:* %cd %an <%ae> VERSION%n- %s%n" packaging/rpm/microshift.spec | |||
| %changelog | |||
| * Wed Jan 24 2024 Patryk Matuszak <pmatusza@redhat.com> 4.16.0 | |||
There was a problem hiding this comment.
Since we're releasing this feature in 4.15, do you mind putting 4.15.0 here as a version?
This should also allow us to cherry pick the change as is.
There was a problem hiding this comment.
great idea, will help me avoid manual cherry pick :)
pmtk
force-pushed
the
2214-microshift-olm-dependency
branch
from
1209ae1
to
d164b8b
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.15 |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@pmtk: new pull request created: #2926 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.