USHIFT-2224: Rename CRI-O configs to include prefix

[pmtk]

Renaming existing CRI-O configs to later introduce 12-microshift-multus.conf that will override cni_default_network

[openshift-ci-robot]

@pmtk: This pull request references USHIFT-2224 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Renaming existing CRI-O configs to later introduce 12-microshift-multus.conf that will override cni_default_network

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ggiguash]

What happens if we have an existing package with crio/crio.conf.d/microshift.conf file installed and we uograde to a new one? Do we end up having both files?

[pmtk]

I checked that and seems that updating is actually removing old and installing new (notice cleanup is done against older c831 version):

  Upgrading        : microshift-4.16.0_0.nightly_2024_01_31_073538_20240202100244_acd1e6272-1.el9.x86_64                                                           4/12
  Running scriptlet: microshift-4.16.0_0.nightly_2024_01_31_073538_20240202100244_acd1e6272-1.el9.x86_64                                                           4/12
  Running scriptlet: microshift-4.16.0_0.nightly_2024_01_31_073538_20240201204716_c8318134a-1.el9.x86_64                                                           9/12
  Cleanup          : microshift-4.16.0_0.nightly_2024_01_31_073538_20240201204716_c8318134a-1.el9.x86_64                                                           9/12
  Verifying        : microshift-4.16.0_0.nightly_2024_01_31_073538_20240202100244_acd1e6272-1.el9.x86_64                                                           1/12
  Verifying        : microshift-4.16.0_0.nightly_2024_01_31_073538_20240201204716_c8318134a-1.el9.x86_64                                                           2/12

Also, contents of the etc/crio/crio.conf.d are as expected:

$ ls /etc/crio/crio.conf.d/
microshift.conf  microshift-ovn.conf

# after update

$ ls /etc/crio/crio.conf.d/
10-microshift.conf  11-microshift-ovn.conf

[ggiguash]

/lgtm

[ggiguash]

/lgtm cancel
Needs rebase

[ggiguash]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ggiguash,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 90d246c and 2 for PR HEAD d8ed04d in total

[openshift-ci]

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.