Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2230: OLM release info files are no longer included in the base release-info RPM package #2934

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

ggiguash
Copy link
Contributor

Before the fix:

$ rpm2cpio ./_output/rpmbuild/RPMS/noarch/microshift-release-info-4.16.0_0.*.el9.noarch.rpm | cpio -it
./usr/share/microshift
./usr/share/microshift/blueprint
./usr/share/microshift/blueprint/blueprint-aarch64.toml
./usr/share/microshift/blueprint/blueprint-x86_64.toml
./usr/share/microshift/release
./usr/share/microshift/release/release-aarch64.json
./usr/share/microshift/release/release-olm-aarch64.json
./usr/share/microshift/release/release-olm-x86_64.json
./usr/share/microshift/release/release-x86_64.json
29 blocks

After the fix:

$ rpm2cpio ./_output/rpmbuild/RPMS/noarch/microshift-release-info-4.16.0_0.*.el9.noarch.rpm | cpio -it
./usr/share/microshift
./usr/share/microshift/blueprint
./usr/share/microshift/blueprint/blueprint-aarch64.toml
./usr/share/microshift/blueprint/blueprint-x86_64.toml
./usr/share/microshift/release
./usr/share/microshift/release/release-aarch64.json
./usr/share/microshift/release/release-x86_64.json
26 blocks

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 25, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 25, 2024

@ggiguash: This pull request references USHIFT-2230 which is a valid jira issue.

In response to this:

Before the fix:

$ rpm2cpio ./_output/rpmbuild/RPMS/noarch/microshift-release-info-4.16.0_0.*.el9.noarch.rpm | cpio -it
./usr/share/microshift
./usr/share/microshift/blueprint
./usr/share/microshift/blueprint/blueprint-aarch64.toml
./usr/share/microshift/blueprint/blueprint-x86_64.toml
./usr/share/microshift/release
./usr/share/microshift/release/release-aarch64.json
./usr/share/microshift/release/release-olm-aarch64.json
./usr/share/microshift/release/release-olm-x86_64.json
./usr/share/microshift/release/release-x86_64.json
29 blocks

After the fix:

$ rpm2cpio ./_output/rpmbuild/RPMS/noarch/microshift-release-info-4.16.0_0.*.el9.noarch.rpm | cpio -it
./usr/share/microshift
./usr/share/microshift/blueprint
./usr/share/microshift/blueprint/blueprint-aarch64.toml
./usr/share/microshift/blueprint/blueprint-x86_64.toml
./usr/share/microshift/release
./usr/share/microshift/release/release-aarch64.json
./usr/share/microshift/release/release-x86_64.json
26 blocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and pmtk January 25, 2024 17:03
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 25, 2024
Copy link
Contributor

openshift-ci bot commented Jan 25, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk
Copy link
Member

pmtk commented Jan 26, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 26, 2024
Copy link
Contributor

openshift-ci bot commented Jan 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 1c18ad8 into openshift:main Jan 26, 2024
9 checks passed
@ggiguash
Copy link
Contributor Author

/cherry-pick release-4.15

@openshift-cherrypick-robot

@ggiguash: new pull request created: #2938

In response to this:

/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants