Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-881: Add support for CentOS 9 OS in test harness framework #2941

Merged
merged 7 commits into from
Feb 6, 2024
Merged

USHIFT-881: Add support for CentOS 9 OS in test harness framework #2941

merged 7 commits into from
Feb 6, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Jan 28, 2024 •
edited

  • Add support for new blueprint .image-fetcher type to download arbitrary ISO image or file
  • Add CentOS-specific kickstart installing from CDROM and using microshift-local repo on the hypervisor
  • Mimic the code in configure-vm.sh script for bootstrapping CentOS configuration for MicroShift
  • Update test framework docs to include .image-fetcher description
  • Fix rpm install test that warned on the conflict with the existing /etc/containers/policy.json file

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 28, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 28, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • Add support for new blueprint .image-fetch type to download arbitrary ISO image
  • Add CentOS-specific kickstart installing from CDROM and using microshift-local repo on the hypervisor
  • Mimic the code in configure-vm.sh script for bootstrapping CentOS configuration for MicroShift

TODO:

  • Update test framework docs to include .image-fetch description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 28, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2024
@ggiguash
Copy link
Contributor Author

/test microshift-periodic-tests

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jan 28, 2024

@ggiguash: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test microshift-periodic-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

dhellmann
dhellmann reviewed Jan 28, 2024
View reviewed changes
test/bin/build_images.sh Outdated Show resolved Hide resolved
test/bin/build_images.sh Outdated Show resolved Hide resolved
test/bin/build_images.sh Outdated Show resolved Hide resolved
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@ggiguash ggiguash force-pushed the centos_tests branch 2 times, most recently from 8edf26b to 9dddca5 Compare January 29, 2024 11:43
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 29, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • Add support for new blueprint .image-fetcher type to download arbitrary ISO image or file
  • Add CentOS-specific kickstart installing from CDROM and using microshift-local repo on the hypervisor
  • Mimic the code in configure-vm.sh script for bootstrapping CentOS configuration for MicroShift

TODO:

  • Update test framework docs to include .image-fetch description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the centos_tests branch 2 times, most recently from 6016916 to a4e0aae Compare January 29, 2024 18:49
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

1 similar comment
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 30, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • Add support for new blueprint .image-fetcher type to download arbitrary ISO image or file
  • Add CentOS-specific kickstart installing from CDROM and using microshift-local repo on the hypervisor
  • Mimic the code in configure-vm.sh script for bootstrapping CentOS configuration for MicroShift

TODO:

  • Update test framework docs to include .image-fetcher description

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@ggiguash ggiguash marked this pull request as ready for review January 30, 2024 11:18
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 30, 2024
@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 1, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-881 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

  • Add support for new blueprint .image-fetcher type to download arbitrary ISO image or file
  • Add CentOS-specific kickstart installing from CDROM and using microshift-local repo on the hypervisor
  • Mimic the code in configure-vm.sh script for bootstrapping CentOS configuration for MicroShift
  • Update test framework docs to include .image-fetcher description
  • Fix rpm install test that warned on the conflict with the existing /etc/containers/policy.json file

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented Feb 1, 2024

/test metal-periodic-test-arm

dhellmann
dhellmann reviewed Feb 1, 2024
View reviewed changes
test/bin/build_images.sh Outdated Show resolved Hide resolved
@ggiguash
Copy link
Contributor Author

ggiguash commented Feb 2, 2024

/test microshift-metal-tests-arm metal-periodic-test

@ggiguash
Copy link
Contributor Author

ggiguash commented Feb 2, 2024

/test metal-periodic-test

1 similar comment
@ggiguash
Copy link
Contributor Author

ggiguash commented Feb 3, 2024

/test metal-periodic-test

pmtk
pmtk reviewed Feb 5, 2024
View reviewed changes
test/bin/scenario.sh Outdated Show resolved Hide resolved
@ggiguash
Copy link
Contributor Author

ggiguash commented Feb 5, 2024

FIPS failure, not related to CentOS changes
/override ci/prow/metal-periodic-test

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 5, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test

In response to this:

FIPS failure, not related to CentOS changes
/override ci/prow/metal-periodic-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk
Copy link
Member

pmtk commented Feb 6, 2024

nice!
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 6, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 524e9af and 2 for PR HEAD 5a916f3 in total

@ggiguash
Copy link
Contributor Author

ggiguash commented Feb 6, 2024

/override ci/prow/metal-periodic-test-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test-arm

In response to this:

/override ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 34cbb63 into openshift:main Feb 6, 2024
8 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Feb 6, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggiguash ggiguash deleted the centos_tests branch February 7, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmtk pmtk pmtk left review comments

@pacevedom pacevedom Awaiting requested review from pacevedom

@pliurh pliurh Awaiting requested review from pliurh

@dhellmann dhellmann Awaiting requested review from dhellmann

Assignees

@pmtk pmtk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ggiguash @openshift-ci-robot @pmtk @dhellmann