Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2247: Remove /usr/libexec/cni from CRI-O conf #2955

Merged

Conversation

pmtk
Copy link
Member

@pmtk pmtk commented Jan 31, 2024

containernetworking-plugins RPM which is a dependency of CRI-O installs
CNIs to /usr/libexec/cni but we don't want to use them because as part
of Multus integration we will get CNIs from container image shipped
with OpenShift.

containernetworking-plugins RPM which is a dependency of CRI-O installs
CNIs to /usr/libexec/cni but we don't want to use them because as part
of Multus integration we will get CNIs from container image shipped
with OpenShift.
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@pmtk
Copy link
Member Author

pmtk commented Jan 31, 2024

/test ?

Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@pmtk: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus
  • pull-ci-openshift-microshift-main-ocp-conformance-rhel-eus-arm
  • pull-ci-openshift-microshift-main-test-rpm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@pmtk
Copy link
Member Author

pmtk commented Jan 31, 2024

/test microshift-metal-tests ocp-conformance-rhel-eus-arm

@pmtk pmtk marked this pull request as ready for review January 31, 2024 15:39
Copy link
Contributor

openshift-ci bot commented Jan 31, 2024

@pmtk: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@pmtk pmtk changed the title WIP: Remove /usr/libexec/cni from CRI-O conf USHIFT-2247: Remove /usr/libexec/cni from CRI-O conf Jan 31, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jan 31, 2024

@pmtk: This pull request references USHIFT-2247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

containernetworking-plugins RPM which is a dependency of CRI-O installs
CNIs to /usr/libexec/cni but we don't want to use them because as part
of Multus integration we will get CNIs from container image shipped
with OpenShift.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 31, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 31, 2024
@eggfoobar
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2024
Copy link
Contributor

openshift-ci bot commented Feb 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eggfoobar, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit e06b4e4 into openshift:main Feb 2, 2024
9 checks passed
@pmtk pmtk deleted the multus/crio-remove-libexec branch May 17, 2024 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants