Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2362: Update origin #3008

Merged
merged 5 commits into from
Feb 14, 2024
Merged

Conversation

pacevedom
Copy link
Contributor

Update origin fork to latest version and:

  • Use submodules. Eases updates.
  • Use patches. Eases cherry-picking changes when updating code base. Eases carry patching to upstream.
  • Adapt run.sh to handle everything automatically.

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link

@pacevedom: No Jira issue with key USHIFT-2632 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

In response to this:

Update origin fork to latest version and:

  • Use submodules. Eases updates.
  • Use patches. Eases cherry-picking changes when updating code base. Eases carry patching to upstream.
  • Adapt run.sh to handle everything automatically.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pacevedom
Copy link
Contributor Author

/hold
Fixing an issue with synthetic monitor tests

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 13, 2024
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 13, 2024
@pacevedom pacevedom changed the title USHIFT-2632: Update origin USHIFT-2362: Update origin Feb 14, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 14, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 14, 2024

@pacevedom: This pull request references USHIFT-2362 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

Update origin fork to latest version and:

  • Use submodules. Eases updates.
  • Use patches. Eases cherry-picking changes when updating code base. Eases carry patching to upstream.
  • Adapt run.sh to handle everything automatically.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2024
@pacevedom pacevedom marked this pull request as ready for review February 14, 2024 09:28
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2024
@pacevedom
Copy link
Contributor Author

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 14, 2024
@openshift-ci openshift-ci bot requested review from jogeo and pmtk February 14, 2024 09:30
@pmtk
Copy link
Member

pmtk commented Feb 14, 2024

I like this. Much better overview of the diff compared to openshift/origin.

@pmtk
Copy link
Member

pmtk commented Feb 14, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2024
Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

openshift-ci bot commented Feb 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit ddb2c85 into openshift:main Feb 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants