USHIFT-2225: Create CRI-O cfg to use Multus over ovn-k #3064
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request references USHIFT-2225 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
| plugin_dirs = [ | ||
| "/opt/cni/bin", | ||
| "/usr/libexec/cni" | ||
| ] |
There was a problem hiding this comment.
Looking at the ovn config file, we also have crio.runtime.workloads.management to pin the CPU 0.
Should we duplicate it here as well so that the config is self-contained?
There was a problem hiding this comment.
It's not needed, These are overrides over what's present in the other file - we'll install both files. The lines you commented are in different order.
There was a problem hiding this comment.
Yes, it's not needed now, but if we're talking about potential separation of network drivers, shouldn't we keep each file self-contained?
At least, can we add a comment that we expect the network driver to be restricted to CPU 0 and the configuration is elsewhere?
There was a problem hiding this comment.
I don't think this works like that - it seems to be using annotations to target specific Pods, target.workload.openshift.io/management in this case and that annotation is also present in manifests of csi-snapshotter, dns, node-resolver, router, service-ca, and OLM. If anything, that configuration should be in 10-microshift.conf and if other CNIs should make use of it, they should include that annotation in the manifests.
There was a problem hiding this comment.
I see. Thank you for explaining.
We should better refactor it in a different PR then.
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.