Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2086: Expose router as LoadBalancer service #3087

Merged
merged 4 commits into from
Mar 11, 2024

Conversation

pacevedom
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 29, 2024

@pacevedom: This pull request references USHIFT-2086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 29, 2024
@openshift-ci openshift-ci bot requested review from copejon and jogeo February 29, 2024 11:19
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 29, 2024
@pacevedom
Copy link
Contributor Author

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@pacevedom
Copy link
Contributor Author

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 29, 2024
@pacevedom
Copy link
Contributor Author

/test microshift-metal-tests

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ShudiLi
Copy link
Member

ShudiLi commented Mar 5, 2024

the function of load balancer service worked well

  1. the load balancer service has an EXTERNAL-IP
    % oc -n openshift-ingress get svc
    NAME TYPE CLUSTER-IP EXTERNAL-IP PORT(S) AGE
    router-default LoadBalancer 10.43.253.56 10.192.10.202 80:31823/TCP,443:30414/TCP 21m
    router-internal-default ClusterIP 10.43.176.219 80/TCP,443/TCP,1936/TCP 21m
    %

% oc get route
NAME HOST ADMITTED SERVICE TLS
edge1 edge1-default.apps.example.com True unsec-server3
unsec-server3 unsec-server3-default.apps.example.com True unsec-server3
%

  1. curl the routes from a pod inside the cluster
    % oc rsh centos-pod2
    sh-4.4# curl http://unsec-server3-default.apps.example.com --resolve unsec-server3-default.apps.example.com:80:10.192.10.202
    this a test!
    sh-4.4#
    sh-4.4# curl https://edge1-default.apps.example.com -k --resolve edge1-default.apps.example.com:443:10.192.10.202
    this a test!

% oc -n openshift-ingress get svc router-default -oyaml
apiVersion: v1
kind: Service
metadata:
annotations:
operator.openshift.io/spec-hash: 5cf4980f2c4ba3534013dbed7bcd9dcab241312dba7f2d9111f13d2c1132e917
creationTimestamp: "2024-03-05T06:37:38Z"
labels:
app: router
ingresscontroller.operator.openshift.io/deployment-ingresscontroller: default
name: router-default
namespace: openshift-ingress
resourceVersion: "495"
uid: 5945ea2a-4f59-40df-8731-2d36e22285da
spec:
allocateLoadBalancerNodePorts: true
clusterIP: 10.43.253.56
clusterIPs:

  • 10.43.253.56
    externalTrafficPolicy: Local
    healthCheckNodePort: 30310
    internalTrafficPolicy: Cluster
    ipFamilies:
  • IPv4
    ipFamilyPolicy: SingleStack
    ports:
  • name: http
    nodePort: 31823
    port: 80
    protocol: TCP
    targetPort: http
  • name: https
    nodePort: 30414
    port: 443
    protocol: TCP
    targetPort: https
    selector:
    ingresscontroller.operator.openshift.io/deployment-ingresscontroller: default
    sessionAffinity: None
    type: LoadBalancer
    status:
    loadBalancer:
    ingress:
    • ip: 10.192.10.202

@ShudiLi
Copy link
Member

ShudiLi commented Mar 5, 2024

/label qe-approved
thanks

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Mar 5, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2024

@pacevedom: This pull request references USHIFT-2086 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member

pmtk commented Mar 11, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 11, 2024
Copy link
Contributor

openshift-ci bot commented Mar 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a43b835 into openshift:main Mar 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants