USHIFT-2286: Use timeout command for interrupting failed VM installations

[ggiguash]

The fix comes to work around stuck VM installations when the ostree payload cannot be pulled.
The --wait <time> option of virt-install does not terminate the tclsh process used by the unbuffer command.

When timeout is used, all the process chain of unbuffer->sudo->virt-install is terminated.

Note: this problem is reproducing itself on ARM platform (not on x86) as noted in the JIRA issue comments.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-2286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

The fix comes to work around stuck VM installations when the ostree payload cannot be pulled.
The --wait <time> option of virt-install does not terminate the tclsh process due to the usage of unbuffer command.

When timeout is used, all the process chain of unbuffer->sudo->virt-install is terminated.

Note: this problem is reproducing itself on ARM platform (not on x86) as noted in the JIRA issue comments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@ggiguash: This pull request references USHIFT-2286 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

The fix comes to work around stuck VM installations when the ostree payload cannot be pulled.
The --wait <time> option of virt-install does not terminate the tclsh process used by the unbuffer command.

When timeout is used, all the process chain of unbuffer->sudo->virt-install is terminated.

Note: this problem is reproducing itself on ARM platform (not on x86) as noted in the JIRA issue comments.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dhellmann]

/lgtm

/hold

This looks good, but I don't want to merge a CI change on Friday evening. Feel free to remove the hold when you're back online next week.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,ggiguash]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ggiguash]

/unhold
/cherry-pick release-4.15

[openshift-cherrypick-robot]

@ggiguash: once the present PR merges, I will cherry-pick it on top of release-4.15 in a new PR and assign it to you.

In response to this:

/unhold
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-cherrypick-robot]

@ggiguash: #3088 failed to apply on top of branch "release-4.15":

Applying: Use timeout command for interrupting VM installations
Using index info to reconstruct a base tree...
M	test/bin/scenario.sh
Falling back to patching base and 3-way merge...
Auto-merging test/bin/scenario.sh
CONFLICT (content): Merge conflict in test/bin/scenario.sh
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Use timeout command for interrupting VM installations
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/unhold
/cherry-pick release-4.15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.