Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2474: remove gh dependency in release notes script #3096

Conversation

dhellmann
Copy link
Contributor

@dhellmann dhellmann commented Mar 1, 2024

  • Use the REST API directly instead of shelling out to 'gh'.
  • Add 4.15 to the list of releases that do not need to be scanned for
    pre-release versions.

Sample output:

Fetching https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.16.0-ec.3/el9/os/rpm_list ...
Examining RPM microshift-4.16.0~ec.3-202402222105.p0.ge2e8447.assembly.ec.3.el9.x86_64.rpm
Checking for release 4.16.0-ec.3-202402222105.p0...
GET https://api.github.com/repos/openshift/microshift/releases/tags/4.16.0-ec.3-202402222105.p0 {}
Not found

POST https://api.github.com/repos/openshift/microshift/releases {'tag_name': '4.16.0-ec.3-202402222105.p0', 'name': '4.16.0-ec.3-202402222105.p0', 'body': '\nThis is a candidate release for 4.16.0.\n\nSee the mirror for build artifacts:\n- https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.16.0-ec.3/\n- https://mirror.openshift.com/pub/openshift-v4/aarch64/microshift/ocp-dev-preview/4.16.0-ec.3/\n\n', 'draft': False, 'prerelease': True, 'generate_release_notes': True}
Created new release 4.16.0-ec.3-202402222105.p0

https://github.com/openshift/microshift/releases/tag/4.16.0-ec.3-202402222105.p0


This is a candidate release for 4.16.0.

  1 USHIFT-2474: remove gh dependency in release notes script
See the mirror for build artifacts:
- https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.16.0-ec.3/
- https://mirror.openshift.com/pub/openshift-v4/aarch64/microshift/ocp-dev-preview/4.16.0-ec.3/



## What's Changed
* USHIFT-881: Add support for CentOS 9 OS in test harness framework by @ggiguash in https://github.com/openshift/microshift/pull/2941
* Revert "USHIFT-2247: Remove /usr/libexec/cni from CRI-O conf" by @pmtk in https://github.com/openshift/microshift/pull/2979
* USHIFT-2257: detect the released RPMs using the current system architecture by @dhellmann in https://github.com/openshift/microshift/pull/2968
* USHIFT-2263: Add env var driven origin test list by @pacevedom in https://github.com/openshift/microshift/pull/2978
* Revert "USHIFT-2253: Improve microshift start time by reducing readiness checks intervals" by @pmtk in https://github.com/openshift/microshift/pull/2980
* USHIFT-2266: have the release note script handle the tag commands by @dhellmann in https://github.com/openshift/microshift/pull/2982
* USHIFT-2345: Work around broken osbuild dependency on RHEL 9.3 by @ggiguash in https://github.com/openshift/microshift/pull/2989
* OCPBUGS-27849: Create microshift-olm-release-info RPM by @pmtk in https://github.com/openshift/microshift/pull/2923
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-07-200316_amd64-2024-02-07_arm64-2024-02-07 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/2988
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-07 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/2996
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-09 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/2999
* USHIFT-2367: documentation preview build scripts by @dhellmann in https://github.com/openshift/microshift/pull/3002
* USHIFT-2367: Minor enhancements of docs-preview scripts by @ggiguash in https://github.com/openshift/microshift/pull/3007
* NO-ISSUE: Revert commits by @agullon in https://github.com/openshift/microshift/pull/3009
* USHIFT-2118: Add 2 RF test for Cluster ID feature by @agullon in https://github.com/openshift/microshift/pull/3000
* OCPBUGS-29271: Rebase lvms registry.access.redhat.com lvms4 lvms operator bundle v4.15.0 by @jakobmoellerdev in https://github.com/openshift/microshift/pull/2993
* USHIFT-2362: Update origin by @pacevedom in https://github.com/openshift/microshift/pull/3008
* USHIFT-2377: update getting started docs to point to 4.14 by @dhellmann in https://github.com/openshift/microshift/pull/3018
* USHIFT-2366:  include e2e.log in  CNCF  conformance artifacts by @eslutsky in https://github.com/openshift/microshift/pull/3001
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-14 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/3021
* USHIFT-2345: Revert "Work around broken osbuild dependency on RHEL 9.3" by @ggiguash in https://github.com/openshift/microshift/pull/3023
* USHIFT-2374: Add option to pull images on configure-vm by @pacevedom in https://github.com/openshift/microshift/pull/3016
* USHIFT-2374: Move pull images after starting crio by @pacevedom in https://github.com/openshift/microshift/pull/3027
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-15 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/3030
* USHIFT-2378: change sonobuoy command to match  the CNCF readme by @eslutsky in https://github.com/openshift/microshift/pull/3026
* USHIFT-2382: Increase timeout for osconfig periodic scenario by @pacevedom in https://github.com/openshift/microshift/pull/3032
* USHIFT-2286: Specify per-platform console device names when starting VMs by @ggiguash in https://github.com/openshift/microshift/pull/3033
* USHIFT-2392: require story points and set target version on jira tickets by @dhellmann in https://github.com/openshift/microshift/pull/3040
* USHIFT-2391: remove FDO scenario by @dhellmann in https://github.com/openshift/microshift/pull/3038
* USHIFT-2430: when closing check story points before dry-run flag by @dhellmann in https://github.com/openshift/microshift/pull/3047
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-17-094036_amd64-2024-02-17_arm64-2024-02-19 by @pacevedom in https://github.com/openshift/microshift/pull/3042
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-17-094036_amd64-2024-02-17_arm64-2024-02-21 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/3054
* USHIFT-2344: Add layer4 image-blueprints to support creating images with RPMs buillt elsewhere by @jogeo in https://github.com/openshift/microshift/pull/3012


**Full Changelog**: https://github.com/openshift/microshift/compare/4.16.0-ec.2-202402052158.p0...4.16.0-ec.3-202402222105.p0

/assign @ggiguash @pacevedom

* Use the REST API directly instead of shelling out to 'gh'.
* Add 4.15 to the list of releases that do not need to be scanned for
  pre-release versions.
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2024

@dhellmann: This pull request references USHIFT-2474 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • Use the REST API directly instead of shelling out to 'gh'.
  • Add 4.15 to the list of releases that do not need to be scanned for
    pre-release versions.

/assign @ggiguash @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 1, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 1, 2024

@dhellmann: This pull request references USHIFT-2474 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set.

In response to this:

  • Use the REST API directly instead of shelling out to 'gh'.
  • Add 4.15 to the list of releases that do not need to be scanned for
    pre-release versions.

Sample output:

Fetching https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.16.0-ec.3/el9/os/rpm_list ...
Examining RPM microshift-4.16.0~ec.3-202402222105.p0.ge2e8447.assembly.ec.3.el9.x86_64.rpm
Checking for release 4.16.0-ec.3-202402222105.p0...
GET https://api.github.com/repos/openshift/microshift/releases/tags/4.16.0-ec.3-202402222105.p0 {}
Not found

POST https://api.github.com/repos/openshift/microshift/releases {'tag_name': '4.16.0-ec.3-202402222105.p0', 'name': '4.16.0-ec.3-202402222105.p0', 'body': '\nThis is a candidate release for 4.16.0.\n\nSee the mirror for build artifacts:\n- https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.16.0-ec.3/\n- https://mirror.openshift.com/pub/openshift-v4/aarch64/microshift/ocp-dev-preview/4.16.0-ec.3/\n\n', 'draft': False, 'prerelease': True, 'generate_release_notes': True}
Created new release 4.16.0-ec.3-202402222105.p0

https://github.com/openshift/microshift/releases/tag/4.16.0-ec.3-202402222105.p0


This is a candidate release for 4.16.0.

 1 [USHIFT-2474](https://issues.redhat.com//browse/USHIFT-2474): remove gh dependency in release notes script
See the mirror for build artifacts:
- https://mirror.openshift.com/pub/openshift-v4/x86_64/microshift/ocp-dev-preview/4.16.0-ec.3/
- https://mirror.openshift.com/pub/openshift-v4/aarch64/microshift/ocp-dev-preview/4.16.0-ec.3/



## What's Changed
* [USHIFT-881](https://issues.redhat.com//browse/USHIFT-881): Add support for CentOS 9 OS in test harness framework by @ggiguash in https://github.com/openshift/microshift/pull/2941
* Revert "[USHIFT-2247](https://issues.redhat.com//browse/USHIFT-2247): Remove /usr/libexec/cni from CRI-O conf" by @pmtk in https://github.com/openshift/microshift/pull/2979
* [USHIFT-2257](https://issues.redhat.com//browse/USHIFT-2257): detect the released RPMs using the current system architecture by @dhellmann in https://github.com/openshift/microshift/pull/2968
* [USHIFT-2263](https://issues.redhat.com//browse/USHIFT-2263): Add env var driven origin test list by @pacevedom in https://github.com/openshift/microshift/pull/2978
* Revert "[USHIFT-2253](https://issues.redhat.com//browse/USHIFT-2253): Improve microshift start time by reducing readiness checks intervals" by @pmtk in https://github.com/openshift/microshift/pull/2980
* [USHIFT-2266](https://issues.redhat.com//browse/USHIFT-2266): have the release note script handle the tag commands by @dhellmann in https://github.com/openshift/microshift/pull/2982
* [USHIFT-2345](https://issues.redhat.com//browse/USHIFT-2345): Work around broken osbuild dependency on RHEL 9.3 by @ggiguash in https://github.com/openshift/microshift/pull/2989
* OCPBUGS-27849: Create microshift-olm-release-info RPM by @pmtk in https://github.com/openshift/microshift/pull/2923
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-07-200316_amd64-2024-02-07_arm64-2024-02-07 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/2988
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-07 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/2996
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-09 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/2999
* [USHIFT-2367](https://issues.redhat.com//browse/USHIFT-2367): documentation preview build scripts by @dhellmann in https://github.com/openshift/microshift/pull/3002
* [USHIFT-2367](https://issues.redhat.com//browse/USHIFT-2367): Minor enhancements of docs-preview scripts by @ggiguash in https://github.com/openshift/microshift/pull/3007
* NO-ISSUE: Revert commits by @agullon in https://github.com/openshift/microshift/pull/3009
* [USHIFT-2118](https://issues.redhat.com//browse/USHIFT-2118): Add 2 RF test for Cluster ID feature by @agullon in https://github.com/openshift/microshift/pull/3000
* OCPBUGS-29271: Rebase lvms registry.access.redhat.com lvms4 lvms operator bundle v4.15.0 by @jakobmoellerdev in https://github.com/openshift/microshift/pull/2993
* [USHIFT-2362](https://issues.redhat.com//browse/USHIFT-2362): Update origin by @pacevedom in https://github.com/openshift/microshift/pull/3008
* [USHIFT-2377](https://issues.redhat.com//browse/USHIFT-2377): update getting started docs to point to 4.14 by @dhellmann in https://github.com/openshift/microshift/pull/3018
* [USHIFT-2366](https://issues.redhat.com//browse/USHIFT-2366):  include e2e.log in  CNCF  conformance artifacts by @eslutsky in https://github.com/openshift/microshift/pull/3001
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-14 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/3021
* [USHIFT-2345](https://issues.redhat.com//browse/USHIFT-2345): Revert "Work around broken osbuild dependency on RHEL 9.3" by @ggiguash in https://github.com/openshift/microshift/pull/3023
* [USHIFT-2374](https://issues.redhat.com//browse/USHIFT-2374): Add option to pull images on configure-vm by @pacevedom in https://github.com/openshift/microshift/pull/3016
* [USHIFT-2374](https://issues.redhat.com//browse/USHIFT-2374): Move pull images after starting crio by @pacevedom in https://github.com/openshift/microshift/pull/3027
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-08-073857_amd64-2024-02-08_arm64-2024-02-15 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/3030
* [USHIFT-2378](https://issues.redhat.com//browse/USHIFT-2378): change sonobuoy command to match  the CNCF readme by @eslutsky in https://github.com/openshift/microshift/pull/3026
* [USHIFT-2382](https://issues.redhat.com//browse/USHIFT-2382): Increase timeout for osconfig periodic scenario by @pacevedom in https://github.com/openshift/microshift/pull/3032
* [USHIFT-2286](https://issues.redhat.com//browse/USHIFT-2286): Specify per-platform console device names when starting VMs by @ggiguash in https://github.com/openshift/microshift/pull/3033
* [USHIFT-2392](https://issues.redhat.com//browse/USHIFT-2392): require story points and set target version on jira tickets by @dhellmann in https://github.com/openshift/microshift/pull/3040
* [USHIFT-2391](https://issues.redhat.com//browse/USHIFT-2391): remove FDO scenario by @dhellmann in https://github.com/openshift/microshift/pull/3038
* [USHIFT-2430](https://issues.redhat.com//browse/USHIFT-2430): when closing check story points before dry-run flag by @dhellmann in https://github.com/openshift/microshift/pull/3047
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-17-094036_amd64-2024-02-17_arm64-2024-02-19 by @pacevedom in https://github.com/openshift/microshift/pull/3042
* NO-ISSUE: rebase-main-4.16.0-0.nightly-2024-02-17-094036_amd64-2024-02-17_arm64-2024-02-21 by @microshift-rebase-script in https://github.com/openshift/microshift/pull/3054
* [USHIFT-2344](https://issues.redhat.com//browse/USHIFT-2344): Add layer4 image-blueprints to support creating images with RPMs buillt elsewhere by @jogeo in https://github.com/openshift/microshift/pull/3012


**Full Changelog**: https://github.com/openshift/microshift/compare/4.16.0-ec.2-202402052158.p0...4.16.0-ec.3-202402222105.p0

/assign @ggiguash @pacevedom

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from copejon and pliurh March 1, 2024 18:27
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2024
@dhellmann
Copy link
Contributor Author

Jobs are failing with unrelated issue:

warning: input image stream has multiple versions defined for version kubectl for all the tags 1.29.0,1.29.1,1.28.2

/retest-required

@ggiguash
Copy link
Contributor

ggiguash commented Mar 3, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Mar 3, 2024
Copy link
Contributor

openshift-ci bot commented Mar 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Mar 3, 2024

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e181bd9 into openshift:main Mar 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants