USHIFT-2431: Add junit integration to CNCF tests #3108
Conversation
|
@ggiguash: This pull request references USHIFT-2431 which is a valid jira issue. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
openshift-ci
bot
added
the
approved
|
/test ? |
|
@ggiguash: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test metal-periodic-test |
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| start_junit | ||
| trap "close_junit" EXIT |
There was a problem hiding this comment.
The framework creates and closes the file, so you don't want these 2 lines. Calling start_junit again will overwrite any existing content and having the trap will cause the file to be closed twice so the syntax is not correct.
There was a problem hiding this comment.
@dhellmann , it looks like the tests do not work without this change.
The reason is because the junit is initialized in run_tests function, which is never called for CNCF.
I have to return the code back
There was a problem hiding this comment.
This function is the plugin interface used by run_tests. If run_tests is not called, then these lines wouldn't do anything, right?
There was a problem hiding this comment.
Looking at scenario.sh, running tests is a separate action and it calls action_run function. This function is different from action_create because it does not directly call start_junit.
The latter is only called inside run_tests function (RF invocation), which is never used in the CNCF test because it's not written using RF.
One possible solution to this problem would be to move the following block to action_run instead of run_tests.
start_junit
trap "close_junit; sos_report" EXIT
Then, it will always be called regardless of what's executed in the scenario run.
There was a problem hiding this comment.
I uploaded this implementation - let me know what you think.
|
/assign @dhellmann @pacevedom |
|
/test metal-periodic-test microshift-metal-tests |
|
/lgtm I like the change to move the junit setup into the action function. It's much more consistent. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.