USHIFT-2555: detect existing VM in scenario.sh create #3128
Conversation
virt-install reports errors, but with the retry loop it can take a while before the script exits when the VM already exists. Add a check for that case and return early. Treat it as not an error, since the instruction is to ensure the VM exists and it does.
|
@dhellmann: This pull request references USHIFT-2555 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
the
approved
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ggiguash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override ci/prow-metal-periodic-test Overriding test for non-production code change. |
|
@dhellmann: /override requires failed status contexts, check run or a prowjob name to operate on.
Only the following failed contexts/checkruns were expected:
If you are trying to override a checkrun that has a space in it, you must put a double quote on the context. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override ci/prow/metal-periodic-test |
|
@dhellmann: Overrode contexts on behalf of dhellmann: ci/prow/metal-periodic-test In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@dhellmann: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
virt-install reports errors, but with the retry loop it can take a
while before the script exits when the VM already exists. Add a check
for that case and return early. Treat it as not an error, since the
instruction is to ensure the VM exists and it does.
/assign @ggiguash