USHIFT-2229: Test Multus - ipvlan CNI #3156
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pmtk: This pull request references USHIFT-2229 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
/test ? |
|
@pmtk: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
the
approved
|
/test metal-periodic-test microshift-metal-tests-arm |
|
Depends on #3155 |
|
/test metal-periodic-test microshift-metal-tests-arm |
pmtk
force-pushed
the
multus/test/ipvlan
branch
from
5e6895e
to
621f574
Compare
|
/test metal-periodic-test microshift-metal-tests-arm |
pmtk
force-pushed
the
multus/test/ipvlan
branch
from
621f574
to
efc235c
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
| sudo virsh net-update default delete ip-dhcp-range "<range start='192.168.122.2' end='192.168.122.254'/>" --config --live | ||
| sudo virsh net-update default add ip-dhcp-range "<range start='192.168.122.10' end='192.168.122.254'/>" --config --live | ||
| fi | ||
|
|
There was a problem hiding this comment.
I believe we need to make this code more generic. Here's what I have on my machine as a range.
$ sudo virsh net-dumpxml default | grep -A4 'ip address'
<ip address='192.168.100.1' netmask='255.255.255.0' localPtr='yes'>
<dhcp>
<range start='192.168.100.100' end='192.168.100.254'/>
</dhcp>
</ip>
There was a problem hiding this comment.
We already have an isolated-network.xml, which we define for a special case.
I would add a special case new network for this test, rather than changing the default.
There was a problem hiding this comment.
Changed according to the suggestion
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pmtk The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@pmtk: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
No description provided.