Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-31739: Use host directory /run/cni/bin for CNI binaries #3223

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Apr 8, 2024

The /opt/cni/bin host directory will become immutable in some configurations. We need a writable directory for CNI binaries.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 8, 2024
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-31739, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The /opt/cni/bin host directory will become immutable in some configurations. We need a writable directory for CNI binaries.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jerpeter1 and jogeo April 8, 2024 06:46
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2024
@pliurh
Copy link
Contributor Author

pliurh commented Apr 8, 2024

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Apr 8, 2024
@openshift-ci-robot
Copy link

@pliurh: This pull request references Jira Issue OCPBUGS-31739, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @jogeo

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Apr 8, 2024
Copy link

@s1061123 s1061123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pmtk
Copy link
Member

pmtk commented Apr 8, 2024

Looks good to me. I'll leave it to Giga to do final verification
/assign @ggiguash

@pliurh pliurh changed the title OCPBUGS-31739: Use host directory /var/lib/cni/bin for CNI binaries OCPBUGS-31739: Use host directory /run/cni/bin for CNI binaries Apr 9, 2024
@pliurh pliurh force-pushed the cni_dir branch 2 times, most recently from 71c5e60 to 42c7257 Compare April 9, 2024 05:17
The /opt/cni/bin host directory will become immutable in some
configurations. We need a writable directory for CNI binaries.

Signed-off-by: Peng Liu <pliu@redhat.com>
@pliurh pliurh force-pushed the cni_dir branch 2 times, most recently from 104f6cb to 84a8b4c Compare April 9, 2024 07:06
@pliurh
Copy link
Contributor Author

pliurh commented Apr 9, 2024

/retest-required

@pliurh
Copy link
Contributor Author

pliurh commented Apr 9, 2024

/test metal-bootc-test

/test metal-bootc-test-arm

1 similar comment
@pliurh
Copy link
Contributor Author

pliurh commented Apr 10, 2024

/test metal-bootc-test

/test metal-bootc-test-arm

@ggiguash
Copy link
Contributor

Bootc test problems are not related to the fix. It is due to the missing ISO images that cannot be downloaded from the S3 bucket at the moment.

/override ci/prow/metal-bootc-test
/override ci/prow/metal-bootc-test-arm
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pliurh, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-bootc-test, ci/prow/metal-bootc-test-arm

In response to this:

Bootc test problems are not related to the fix. It is due to the missing ISO images that cannot be downloaded from the S3 bucket at the moment.

/override ci/prow/metal-bootc-test
/override ci/prow/metal-bootc-test-arm
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

@pliurh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 223b3f4 into openshift:main Apr 10, 2024
12 checks passed
@openshift-ci-robot
Copy link

@pliurh: Jira Issue OCPBUGS-31739: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-31739 has been moved to the MODIFIED state.

In response to this:

The /opt/cni/bin host directory will become immutable in some configurations. We need a writable directory for CNI binaries.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants