Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-2967: use oc command with custom-ca #3235

Merged
merged 1 commit into from
Apr 16, 2024
Merged

USHIFT-2967: use oc command with custom-ca #3235

merged 1 commit into from
Apr 16, 2024

Conversation

eslutsky
Copy link
Contributor

Which issue(s) this PR addresses:

Closes #

@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 15, 2024 •
edited by openshift-ci bot

@eslutsky: This pull request references USHIFT-2967 which is a valid jira issue.

In response to this:

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 15, 2024
@openshift-ci openshift-ci bot requested review from jogeo and pmtk April 15, 2024 08:18
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2024
@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@pacevedom pacevedom mentioned this pull request Apr 15, 2024
Merged
ggiguash
ggiguash reviewed Apr 15, 2024
View reviewed changes
test/suites/standard2/validate-custom-certificates.robot
Upload Certificates
Configure Named Certificates ${TMPDIR}/server.crt ${TMPDIR}/server.key
Restart MicroShift
Add Entry To Hosts ${USHIFT_HOST} test-expired.api.com
Setup Custom Kubeconfig test-expired.api.com
Add Entry To Hosts ${USHIFT_HOST} ${hostname}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to clean this up or these host names will pile up in /etc/hosts on dev machines.
Can we delete this entry in Teardown?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@eslutsky
USHIFT-2967: use oc command with custom-ca
148a00d 
Signed-off-by: Evgeny Slutsky <eslutsky@redhat.com>
@eslutsky
Copy link
Contributor Author

/test metal-periodic-test

@eslutsky
Copy link
Contributor Author

/test microshift-metal-tests-arm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 15, 2024

@eslutsky: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ggiguash
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 16, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 16, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eslutsky, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 5c2fa84 into openshift:main Apr 16, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggiguash ggiguash ggiguash left review comments

@jogeo jogeo Awaiting requested review from jogeo

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@ggiguash ggiguash

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eslutsky @openshift-ci-robot @ggiguash