Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USHIFT-2926: Implement bootc-image-builder support for creating CentOS ISO files #3270

Merged
merged 5 commits into from
Apr 26, 2024
Merged

USHIFT-2926: Implement bootc-image-builder support for creating CentOS ISO files #3270

merged 5 commits into from
Apr 26, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented Apr 23, 2024 •
edited by openshift-ci bot

Also addresses USHIFT-2983

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-2926 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 23, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-2926 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Also addresses USHIFT-2983

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented Apr 23, 2024 •
edited by openshift-ci bot

@ggiguash: This pull request references USHIFT-2926 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Also addresses USHIFT-2983

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash force-pushed the parallel_bootc_image_builds branch 3 times, most recently from 51ccac3 to f47fb8d Compare April 23, 2024 12:28
@ggiguash ggiguash changed the title USHIFT-2926: Implement bootc-image-builder support for creating ISO files USHIFT-2926: Implement bootc-image-builder support for creating CentOS ISO files Apr 23, 2024
@ggiguash ggiguash force-pushed the parallel_bootc_image_builds branch from f47fb8d to 1b9904b Compare April 23, 2024 12:30
@ggiguash
Copy link
Contributor Author

/test ?

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 23, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash ggiguash force-pushed the parallel_bootc_image_builds branch from 1b9904b to 41179d1 Compare April 23, 2024 19:13
@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash ggiguash marked this pull request as ready for review April 25, 2024 11:13
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2024
@openshift-ci openshift-ci bot requested review from pliurh and pmtk April 25, 2024 11:14
@ggiguash
Copy link
Contributor Author

Test failures are due to the problem fixed by #3286

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test

@ggiguash
Copy link
Contributor Author

/test metal-bootc-test
/test metal-bootc-test-arm

@ggiguash
Copy link
Contributor Author

/retest-required

@ggiguash
Copy link
Contributor Author

/test microshift-metal-tests-arm

@copejon
Copy link
Contributor

copejon commented Apr 26, 2024

This looks good. Will LGTM as we expect the arm tests to pass now

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 26, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Apr 26, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 70d94bd into openshift:main Apr 26, 2024
10 checks passed
@ggiguash ggiguash deleted the parallel_bootc_image_builds branch April 27, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@pmtk pmtk Awaiting requested review from pmtk

Assignees

@copejon copejon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ggiguash @openshift-ci-robot @copejon