OCPBUGS-32946: Default to watch all interfaces and IPs for router lis…

[pacevedom]

…tenAddress

During first boot MicroShift will start scanning all IP addresses in the host to setup the router load balancer service. When this happens, not all interfaces may have an IP yet, leaving them out until the next microshift restart.

By leaving the defaults empty we allow the IP address subscription handler to add anything that is not forbidden automatically. If this list is fixed with the IPs and interfaces that were present only when MicroShift started, we might miss out on some of hte listening IPs unless the user restarts.

Which issue(s) this PR addresses:

Closes #

[openshift-ci-robot]

@pacevedom: This pull request references Jira Issue OCPBUGS-32946, which is invalid:

• expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…tenAddress

During first boot MicroShift will start scanning all IP addresses in the host to setup the router load balancer service. When this happens, not all interfaces may have an IP yet, leaving them out until the next microshift restart.

By leaving the defaults empty we allow the IP address subscription handler to add anything that is not forbidden automatically. If this list is fixed with the IPs and interfaces that were present only when MicroShift started, we might miss out on some of hte listening IPs unless the user restarts.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pacevedom]

/hold

[pacevedom]

/jira refresh

[openshift-ci-robot]

@pacevedom: This pull request references Jira Issue OCPBUGS-32946, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pacevedom]

/hold cancel

[ShudiLi]

Tested it with cluster-Bot created cluster

1.
% oc -n openshift-ingress get svc
NAME                      TYPE           CLUSTER-IP     EXTERNAL-IP                         PORT(S)                      AGE
router-default            LoadBalancer   10.43.95.21    10.192.10.159,10.42.0.2,10.44.0.0   80:30096/TCP,443:31278/TCP   26m
router-internal-default   ClusterIP      10.43.196.83   <none>                              80/TCP,443/TCP,1936/TCP      26m
% 

2. debug node and check the host's ip address
sh-5.1# ip address | grep "inet " 
    inet 127.0.0.1/8 scope host lo
    inet 10.192.10.159/24 brd 10.192.10.255 scope global dynamic noprefixroute eth0
    inet 10.44.0.0/32 scope global br-ex
    inet 169.254.169.2/29 brd 169.254.169.7 scope global br-ex
    inet 10.42.0.2/24 brd 10.42.0.255 scope global ovn-k8s-mp0
sh-5.1# 

3. configure the config.yaml, then restart the microshift service

4.
shudi@Shudis-MacBook-Pro microshift % oc -n openshift-ingress get svc
NAME                      TYPE           CLUSTER-IP     EXTERNAL-IP               PORT(S)                           AGE
router-default            LoadBalancer   10.43.95.21    10.192.10.159,10.44.0.0   10080:30096/TCP,10443:31278/TCP   27m
router-internal-default   ClusterIP      10.43.196.83   <none>                    80/TCP,443/TCP,1936/TCP           27m

5. removed the custom ip address and ports from the config.yaml, then restart the microshift service
6. 
% oc -n openshift-ingress get svc
NAME                      TYPE           CLUSTER-IP     EXTERNAL-IP                         PORT(S)                      AGE
router-default            LoadBalancer   10.43.95.21    10.192.10.159,10.42.0.2,10.44.0.0   80:30096/TCP,443:31278/TCP   28m
router-internal-default   ClusterIP      10.43.196.83   <none>                              80/TCP,443/TCP,1936/TCP      28m
% 

[ShudiLi]

/label qe-approved
thanks

[openshift-ci-robot]

@pacevedom: This pull request references Jira Issue OCPBUGS-32946, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.16.0) matches configured target version for branch (4.16.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @ShudiLi

In response to this:

…tenAddress

During first boot MicroShift will start scanning all IP addresses in the host to setup the router load balancer service. When this happens, not all interfaces may have an IP yet, leaving them out until the next microshift restart.

By leaving the defaults empty we allow the IP address subscription handler to add anything that is not forbidden automatically. If this list is fixed with the IPs and interfaces that were present only when MicroShift started, we might miss out on some of hte listening IPs unless the user restarts.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[pmtk]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pacevedom, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [pacevedom,pmtk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 58bf2d1 and 2 for PR HEAD 626ecb7 in total

[pacevedom]

/retest-required

[pacevedom]

/test ocp-conformance-rhel-eus

[openshift-ci]

@pacevedom: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci-robot]

@pacevedom: Jira Issue OCPBUGS-32946: All pull requests linked via external trackers have merged:

• openshift/microshift#3285

Jira Issue OCPBUGS-32946 has been moved to the MODIFIED state.

In response to this:

…tenAddress

During first boot MicroShift will start scanning all IP addresses in the host to setup the router load balancer service. When this happens, not all interfaces may have an IP yet, leaving them out until the next microshift restart.

By leaving the defaults empty we allow the IP address subscription handler to add anything that is not forbidden automatically. If this list is fixed with the IPs and interfaces that were present only when MicroShift started, we might miss out on some of hte listening IPs unless the user restarts.

Which issue(s) this PR addresses:

Closes #

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.