-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USHIFT-3113: Enhancements for build_bootc_image.py script #3293
USHIFT-3113: Enhancements for build_bootc_image.py script #3293
Conversation
@ggiguash: This pull request references USHIFT-3113 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
eeaeaab
to
47ab45b
Compare
47ab45b
to
25e1c62
Compare
test/bin/pyutils/common.py
Outdated
pids = [] | ||
for child in children: | ||
pids += [child.pid] | ||
return pids |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This might be a good place to use yield, but up to you. Not that it matters performance wise, but its good practice to do so if you dont need the full list upfront.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this case, I think I'd prefer to simpify the code and not use yield. The list will be very short and collected immediately, I'm not sure there's an advantage of using generators here, or is there?
/assign @pacevedom |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ggiguash, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ggiguash: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
These changes should attain a usability feature parity with the build_images.sh script:
--build-type
argument allows for filtering build by a specified type--no-extract-images
skips container image extraction procedure