Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2963: Start using RHEL-9.4 ISO for booting RHEL-based tests #3318

Merged
merged 4 commits into from
May 3, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented May 3, 2024

Also fixes USHIFT-2926

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2024

@ggiguash: This pull request references USHIFT-2963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Also fixes USHIFT-2926

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 3, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 3, 2024

@ggiguash: This pull request references USHIFT-2963 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to this:

Also fixes USHIFT-2926

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2024
@ggiguash ggiguash marked this pull request as ready for review May 3, 2024 08:27
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 3, 2024
@openshift-ci openshift-ci bot requested review from jerpeter1 and pmtk May 3, 2024 08:28
@ggiguash
Copy link
Contributor Author

ggiguash commented May 3, 2024

/assign @pacevedom

@ggiguash
Copy link
Contributor Author

ggiguash commented May 3, 2024

The failure is not related to the error. Saving CI cycles.
/override ci/prow/metal-periodic-test-arm

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test-arm

In response to this:

The failure is not related to the error. Saving CI cycles.
/override ci/prow/metal-periodic-test-arm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 3, 2024
Copy link
Contributor

openshift-ci bot commented May 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ggiguash
Copy link
Contributor Author

ggiguash commented May 3, 2024

Changes not related to osbuilder tests.
/override ci/prow/metal-periodic-test

Copy link
Contributor

openshift-ci bot commented May 3, 2024

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/metal-periodic-test

In response to this:

Changes not related to osbuilder tests.
/override ci/prow/metal-periodic-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 03055fe into openshift:main May 3, 2024
10 checks passed
@ggiguash ggiguash deleted the rhel94_iso_boot branch May 4, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants