Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-2210: Run FIPS tests on RPM and ostree-based RHEL 9.4 systems #3322

Merged
merged 2 commits into from
May 7, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented May 6, 2024

The FIPS blueprint customization is not supported for edge-commits, so it cannot be used in image-installer due to the current MicroShift bluepring organization. Instead, we explicitly pass fips=1 when booting the VM and call fips-mode-setup in kickstart.

The following message is produced by fips-mode-setup command when run in kickstart.

Setting system policy to FIPS
Note: System-wide crypto policies are applied on application start-up.
It is recommended to restart the system for the change of policies to fully take place.
FIPS mode will be enabled.
Now you need to configure the bootloader to add kernel options "fips=1 boot=UUID=<your-boot-device-uuid>" and reboot the system for the setting to take effect.

Since we are using microshift-source-isolated images for FIPS tests, I had to upgrade those to run RHEL 9.4 OS and fix the dependent scenarios to use these upgraded images. This is anyway part of the work we are doing on RHEL 9.4 transition (CC: @copejon)

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2024
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024

@ggiguash: This pull request references USHIFT-2210 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Copy link
Contributor

openshift-ci bot commented May 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024

@ggiguash: This pull request references USHIFT-2210 which is a valid jira issue.

In response to this:

The FIPS blueprint customization is not supported for edge-commits, so it cannot be used due to the current MicroShift bluepring organization. Instead, we explicitly pass fips=1 when booting the VM, and call fips-mode-setup in kickstart.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024

@ggiguash: This pull request references USHIFT-2210 which is a valid jira issue.

In response to this:

The FIPS blueprint customization is not supported for edge-commits, so it cannot be used due to the current MicroShift bluepring organization. Instead, we explicitly pass fips=1 when booting the VM and call fips-mode-setup in kickstart.

Since we are using microshift-source-isolated images for FIPS tests, I had to upgrade those to run RHEL 9.4 OS and fix the dependent scenarios to use these upgraded images. This is anyway part of the work we are doing on RHEL 9.4 transition (CC: @copejon)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/test ?

Copy link
Contributor

openshift-ci bot commented May 6, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-metal-periodic-test
  • pull-ci-openshift-microshift-main-metal-periodic-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/test metal-periodic-test

@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/test verify

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024

@ggiguash: This pull request references USHIFT-2210 which is a valid jira issue.

In response to this:

The FIPS blueprint customization is not supported for edge-commits, so it cannot be used due to the current MicroShift bluepring organization. Instead, we explicitly pass fips=1 when booting the VM and call fips-mode-setup in kickstart.

The following message is produced by fips-mode-setup command when run in kickstart.

Setting system policy to FIPS
Note: System-wide crypto policies are applied on application start-up.
It is recommended to restart the system for the change of policies to fully take place.
FIPS mode will be enabled.
Now you need to configure the bootloader to add kernel options "fips=1 boot=UUID=<your-boot-device-uuid>" and reboot the system for the setting to take effect.

Since we are using microshift-source-isolated images for FIPS tests, I had to upgrade those to run RHEL 9.4 OS and fix the dependent scenarios to use these upgraded images. This is anyway part of the work we are doing on RHEL 9.4 transition (CC: @copejon)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2024

@ggiguash: This pull request references USHIFT-2210 which is a valid jira issue.

In response to this:

The FIPS blueprint customization is not supported for edge-commits, so it cannot be used in image-installer due to the current MicroShift bluepring organization. Instead, we explicitly pass fips=1 when booting the VM and call fips-mode-setup in kickstart.

The following message is produced by fips-mode-setup command when run in kickstart.

Setting system policy to FIPS
Note: System-wide crypto policies are applied on application start-up.
It is recommended to restart the system for the change of policies to fully take place.
FIPS mode will be enabled.
Now you need to configure the bootloader to add kernel options "fips=1 boot=UUID=<your-boot-device-uuid>" and reboot the system for the setting to take effect.

Since we are using microshift-source-isolated images for FIPS tests, I had to upgrade those to run RHEL 9.4 OS and fix the dependent scenarios to use these upgraded images. This is anyway part of the work we are doing on RHEL 9.4 transition (CC: @copejon)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/assign @copejon @eslutsky

@ggiguash ggiguash marked this pull request as ready for review May 6, 2024 05:44
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
@openshift-ci openshift-ci bot requested review from dhellmann and pmtk May 6, 2024 05:44
@copejon
Copy link
Contributor

copejon commented May 7, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2024
Copy link
Contributor

openshift-ci bot commented May 7, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 6ae64d9 into openshift:main May 7, 2024
10 checks passed
@ggiguash ggiguash deleted the fips_ostree branch May 10, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants