Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USHIFT-3138: Refactor scenarios not to exceed 20m runtime in pre-submits #3326

Merged
merged 3 commits into from
May 9, 2024

Conversation

ggiguash
Copy link
Contributor

@ggiguash ggiguash commented May 6, 2024

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we create periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2024
Copy link
Contributor

openshift-ci bot commented May 6, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/test ?

Copy link
Contributor

openshift-ci bot commented May 6, 2024

@ggiguash: The following commands are available to trigger required jobs:

  • /test images
  • /test metal-bootc-test
  • /test metal-bootc-test-arm
  • /test metal-periodic-test
  • /test metal-periodic-test-arm
  • /test microshift-metal-cache
  • /test microshift-metal-cache-arm
  • /test microshift-metal-tests
  • /test microshift-metal-tests-arm
  • /test ocp-conformance-rhel-eus
  • /test ocp-conformance-rhel-eus-arm
  • /test test-rpm
  • /test test-unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test test-rebase

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-metal-bootc-test
  • pull-ci-openshift-microshift-main-metal-bootc-test-arm
  • pull-ci-openshift-microshift-main-microshift-metal-tests
  • pull-ci-openshift-microshift-main-microshift-metal-tests-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2024
@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/test metal-bootc-test
/test metal-bootc-test-arm

@ggiguash
Copy link
Contributor Author

ggiguash commented May 6, 2024

/test metal-bootc-test
/test metal-bootc-test-arm

@ggiguash ggiguash changed the title Refactor bootc osconfig scenarios not to exceed 20m runtime USHIFT-3138: Refactor bootc osconfig scenarios not to exceed 20m runtime May 7, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash ggiguash marked this pull request as ready for review May 7, 2024 05:05
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 7, 2024
@openshift-ci openshift-ci bot requested review from dhellmann and pliurh May 7, 2024 05:06
@ggiguash ggiguash changed the title USHIFT-3138: Refactor bootc osconfig scenarios not to exceed 20m runtime USHIFT-3138: Refactor scenarios not to exceed 20m runtime in pre-submits May 7, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test to standard 2 to balance them out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we run periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 7, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Reduce the amount of restart attempts in the lifecycle test to reduce the overall runtime without hurting the testability
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we create periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ggiguash
Copy link
Contributor Author

ggiguash commented May 7, 2024

/assign @pmtk

@copejon
Copy link
Contributor

copejon commented May 7, 2024

Can we rename the scenario scripts to something more descriptive? Using osconfig1..5 doesn't indicate much outside of a general context for the scenario under test.

@ggiguash
Copy link
Contributor Author

ggiguash commented May 8, 2024

/test metal-bootc-test-arm

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 9, 2024

@ggiguash: This pull request references USHIFT-3138 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

  • Splitting the osconfig tests to 3 scenarios in bootc only
  • Moving certificate rotation test from standard1 to standard2 to balance them out

Note: when we create periodic tests for bootc, we will likely merge the osconfig tests back into one scenario, similar to what we have in composer-cli periodics.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@pmtk
Copy link
Member

pmtk commented May 9, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
Copy link
Contributor

openshift-ci bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ggiguash, pmtk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

openshift-ci bot commented May 9, 2024

@ggiguash: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0132f83 into openshift:main May 9, 2024
8 checks passed
@ggiguash ggiguash deleted the bootc_osconfig_reorg branch May 10, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants