AUTH-296: split out the service-ca trust chain #947
Conversation
openshift-ci
bot
added
the
do-not-merge/hold
|
/test all |
|
/hold cancel |
openshift-ci
bot
removed
the
do-not-merge/hold
| if rootCA == nil || rootKey == nil { | ||
| return err | ||
| return fmt.Errorf("the root CA cert/key pair was not yet generated") |
There was a problem hiding this comment.
Nit: errors.New would be better.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, ibihim, stlaz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/test e2e-openshift-conformance-sig-storage |
|
@stlaz: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This PR splits out service-ca trust chain from the root CA.
/hold
#939 should be merged first, I'm creating this PR just to see whether splitting out service-ca brings any issues.