Merge pull request #82 from openshift-cherrypick-robot/cherry-pick-78…

…-to-release-4.14 [release-4.14] OCPBUGS-24664: disable query link for non metric-based alerts
openshift · Dec 21, 2023 · a0a1b5a · a0a1b5a
2 parents 8757197 + ef4676f
commit a0a1b5a
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/src/components/alerting.tsx b/src/components/alerting.tsx
@@ -1181,11 +1181,18 @@ const AlertRulesDetailsPage_: React.FC<AlertRulesDetailsPageProps> = ({ match })
                   )}
                   <dt>{t('Expression')}</dt>
                   <dd>
-                    <Link to={queryBrowserURL(rule?.query, namespace)}>
+                    {/* display a link only if its a metrics based alert */}
+                    {!sourceId || sourceId === 'prometheus' ? (
+                      <Link to={queryBrowserURL(rule?.query, namespace)}>
+                        <CodeBlock>
+                          <CodeBlockCode>{rule?.query}</CodeBlockCode>
+                        </CodeBlock>
+                      </Link>
+                    ) : (
                       <CodeBlock>
                         <CodeBlockCode>{rule?.query}</CodeBlockCode>
                       </CodeBlock>
-                    </Link>
+                    )}
                   </dd>
                 </dl>
               </div>