OU-370: Split Dashboard Label and Line Chart Queries #109
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@PeterYurkovich: This pull request references OU-370 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
bot
added
the
approved
|
/jira refresh |
|
@PeterYurkovich: This pull request references OU-370 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target either version "4.16." or "openshift-4.16.", but it targets "OpenShift 4.16" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/jira refresh |
|
@PeterYurkovich: This pull request references OU-370 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
/lgtm cancel |
|
@PeterYurkovich can you please squash the changes? |
PeterYurkovich
force-pushed
the
OU-370-dashboard-timeouts
branch
from
dc06c7c
to
3c20c04
Compare
|
/retest |
|
@PeterYurkovich: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jgbernalp, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[ART PR BUILD NOTIFIER] This PR has been included in build monitoring-plugin-container-v4.16.0-202404021444.p0.g62f0a8c.assembly.stream.el9 for distgit monitoring-plugin. |
Description
Issue: https://issues.redhat.com/browse/OU-370
Queries with a duration of more than 2 days will time out for certain dashboards due to the large time period of data being queried and the density of the data for those queries. Since we know that the shorter queries don't time out, we can split the larger queries time periods down into durations that won't time out (1 day), and then recombine all the returned data.
However, we can only recombine query types which isn't dependent on other dimensions (labels) or that which is directly dependent on time (line charts).
Implementation
The labels query uses a set to keep track of all options for the label across the split queries. The query-browser (line chart) breaks the query down into its needed time chunks, then looks to recombine the data into the original query format, in order to ensure backwards compatibility with query functionality being stored in Redux.