Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OU-308: Revert "fix default nginx path to look for static files" #90

Merged

Conversation

kyoto
Copy link
Member

@kyoto kyoto commented Dec 21, 2023

This change should only have been made for building images for local testing, not in the default Dockerfile.

This reverts PR #83 and commit 4965ae6.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 21, 2023
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

@kyoto: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jgbernalp
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 21, 2023
Copy link
Contributor

openshift-ci bot commented Dec 21, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jgbernalp, kyoto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kyoto kyoto changed the title Revert "fix default nginx path to look for static files" OU-308: Revert "fix default nginx path to look for static files" Dec 21, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 21, 2023
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 21, 2023

@kyoto: This pull request references OU-308 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "OpenShift 4.16" instead.

In response to this:

This change should only have been made for building images for local testing, not in the default Dockerfile.

This reverts PR #83 and commit 4965ae6.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 73a1c3b into openshift:main Dec 21, 2023
3 checks passed
@kyoto kyoto deleted the revert-dockerfile-nginx-config branch December 21, 2023 12:15
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build monitoring-plugin-container-v4.16.0-202312211331.p0.g73a1c3b.assembly.stream for distgit monitoring-plugin.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants