-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MULTIARCH-4547: Add labels, annotations, reconcile konflux and other konflux-related fixes #93
Conversation
e2dcfc5
to
9d45e42
Compare
/retest |
1 similar comment
/retest |
/retest |
17b39c6
to
b1c40dd
Compare
/retest |
b3e6ab2
to
5c2de30
Compare
5c2de30
to
a61e869
Compare
/retest |
2 similar comments
/retest |
/retest |
06f8d12
to
3726fab
Compare
Base image gcr.io/distroless/base:latest is from a disallowed registry
/test e2e-gcp-multi-operator-olm |
/retest |
1 similar comment
/retest |
/approve |
/hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aleskandro The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@aleskandro: This pull request references MULTIARCH-4547 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@aleskandro: This pull request references MULTIARCH-4547 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/lgtm |
/retest-required |
/retest |
New changes are detected. LGTM label has been removed. |
- The gcr.io/ images are not accepted by the ECP - scratch now works but the SBOM's components array is empty
/override "ci/prow/images" "ci/prow/generate" "ci/prow/fmt" "ci/prow/ci-index-multiarch-tuning-operator-bundle" "ci/prow/fmt" ci/prow/vet ci/prow/unit ci/prow/e2e-gcp-multi-operator-olm (just changed the version of gosec, cehcking ci/prow/sast works and merging) |
@aleskandro: Overrode contexts on behalf of aleskandro: ci/prow/ci-index-multiarch-tuning-operator-bundle, ci/prow/e2e-gcp-multi-operator-olm, ci/prow/fmt, ci/prow/generate, ci/prow/images, ci/prow/unit, ci/prow/vet In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest-required |
/override ci/prow/goimports ci/prow/vendor ci/prow/bundle ci/prow/manifests ci/prow/security ci/prow/lint ci/prow/e2e-gcp-multi-operator ci/prow/sast (no resources available and the tests were already looking good. I covered the testing of the last change locally) |
@aleskandro: Overrode contexts on behalf of aleskandro: ci/prow/bundle, ci/prow/e2e-gcp-multi-operator, ci/prow/goimports, ci/prow/lint, ci/prow/manifests, ci/prow/sast, ci/prow/security, ci/prow/vendor In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/override "ci/prow/images" "ci/prow/generate" "ci/prow/fmt" "ci/prow/ci-index-multiarch-tuning-operator-bundle" "ci/prow/fmt" ci/prow/vet ci/prow/unit ci/prow/e2e-gcp-multi-operator-olm |
@aleskandro: Overrode contexts on behalf of aleskandro: ci/prow/ci-index-multiarch-tuning-operator-bundle, ci/prow/e2e-gcp-multi-operator-olm, ci/prow/fmt, ci/prow/generate, ci/prow/images, ci/prow/unit, ci/prow/vet In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@aleskandro: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This should unblock some alerts that prevent us from testing the (staging)
Release
pipelines in Konflux.