New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCPBUGS-29162: Upstream sync to 20240207 #214
OCPBUGS-29162: Upstream sync to 20240207 #214
Conversation
The ClusterRole was missing the watch permission on pods, which resulted in Multus throwing this error message every few seconds: Failed to watch *v1.Pod: unknown (get pods)
…189) Signed-off-by: Moshe Levi <moshele@nvidia.com> Signed-off-by: Tomofumi Hayashi <tohayash@redhat.com>
Fix to use lumberjack only for logging files
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.53.0 to 1.56.3. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.53.0...v1.56.3) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This fix reduces multus-daemon memory usage with k8s 0.29 informer transform to trim unnecessary Pod object information to multus.
As described in #1171, the watch function is required in the clusterrole for the thick Multus version, otherwise "Failed to watch *v1.Pod" would be returned.
… deliver the installation file (#1210) Signed-off-by: Zechun Chen <zechun.chen@daocloud.io>
Add additional sleep in thick entrypoint
/retitle OCPBUGS-29162: Upstream sync to 20240207 |
@s1061123: This pull request references Jira Issue OCPBUGS-29162, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
@s1061123: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/lgtm |
2 similar comments
/lgtm |
/lgtm |
72e609b
into
openshift:master
@s1061123: Jira Issue OCPBUGS-29162: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-29162 has been moved to the MODIFIED state. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[ART PR BUILD NOTIFIER] This PR has been included in build multus-cni-container-v4.16.0-202402141610.p0.g72e609b.assembly.stream.el9 for distgit multus-cni. |
No description provided.