Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-29624: Revert #216 "OCPBUGS-27429: Reload bootstrap kubeconfig if cert mgr failed to load valid certs" #218

Closed
wants to merge 1 commit into from

Conversation

dgoodwin
Copy link

Reverts #216 ; tracked by OCPBUGS-29624

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Test revert only, the linked bug outlines the problem we're facing, revert is just a test to see if we get consistent success or not.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

CC: @s1061123

PR created by Revertomatic™️

This reverts commit 717bf76, reversing
changes made to 72e609b.
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Feb 16, 2024
@openshift-ci-robot
Copy link
Contributor

@dgoodwin: This pull request references Jira Issue OCPBUGS-29624, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Reverts #216 ; tracked by OCPBUGS-29624

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Test revert only, the linked bug outlines the problem we're facing, revert is just a test to see if we get consistent success or not.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

CC: @s1061123

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dgoodwin
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

1 similar comment
@dgoodwin
Copy link
Author

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@dgoodwin: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6d4015e0-ccfe-11ee-8d04-400701396c1b-0

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

@dgoodwin: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/71fdec10-ccfe-11ee-8de3-5dd3edcf5d39-0

Copy link
Contributor

openshift-ci bot commented Feb 16, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: dgoodwin
Once this PR has been reviewed and has the lgtm label, please assign dcbw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dgoodwin
Copy link
Author

/close

Copy link
Contributor

openshift-ci bot commented Feb 20, 2024

@dgoodwin: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Feb 20, 2024
@openshift-ci-robot
Copy link
Contributor

@dgoodwin: This pull request references Jira Issue OCPBUGS-29624. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to this:

Reverts #216 ; tracked by OCPBUGS-29624

Per OpenShift policy, we are reverting this breaking change to get CI and/or nightly payloads flowing again.

Test revert only, the linked bug outlines the problem we're facing, revert is just a test to see if we get consistent success or not.

To unrevert this, revert this PR, and layer an additional separate commit on top that addresses the problem. Before merging the unrevert, please run these jobs on the PR and check the result of these jobs to confirm the fix has corrected the problem:

/payload-job periodic-ci-openshift-release-master-nightly-4.16-e2e-metal-ipi-ovn-ipv6

CC: @s1061123

PR created by Revertomatic™️

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants