New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1827377: Allows allow pods in any namespace refer to net-attach-defs in default namespace #60

Merged

openshift-merge-robot merged 1 commit into openshift:master from dougbtv:downstream-master-pick-ns-isolation-default

Apr 24, 2020

Member

dougbtv commented Apr 22, 2020

When using namespace isolation.


          Allows namespaceIsolation to allow pods in any namespace refer to the…

fb29016

… default namespace

openshift-ci-robot requested review from dcbw and squeed

April 22, 2020 18:51

openshift-ci-robot added the approved label

dougbtv mentioned this pull request

Bug 1827375: Allows allow pods in any namespace refer to net-attach-defs in default namespace #61

Merged

s1061123 approved these changes

View reviewed changes

Contributor

s1061123 left a comment

Looks good to me, thanks!
/lgtm

openshift-ci-robot assigned s1061123

openshift-ci-robot added the lgtm label

Contributor

openshift-ci-robot commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dougbtv,s1061123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

s1061123 changed the title ~~Allows allow pods in any namespace refer to net-attach-defs in default namespace~~ Bug 1827375: Allows allow pods in any namespace refer to net-attach-defs in default namespace

openshift-ci-robot added bugzilla/unspecified bugzilla/invalid-bug labels

Contributor

openshift-ci-robot commented Apr 24, 2020

@dougbtv: This pull request references Bugzilla bug 1827375, which is invalid:

expected the bug to target the "4.5.0" release, but it targets "4.4.z" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1827375: Allows allow pods in any namespace refer to net-attach-defs in default namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s1061123 changed the title ~~Bug 1827375: Allows allow pods in any namespace refer to net-attach-defs in default namespace~~ Bug 1827377: Allows allow pods in any namespace refer to net-attach-defs in default namespace

openshift-ci-robot added bugzilla/valid-bug and removed bugzilla/invalid-bug labels

Contributor

openshift-ci-robot commented Apr 24, 2020

@dougbtv: This pull request references Bugzilla bug 1827377, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1827377: Allows allow pods in any namespace refer to net-attach-defs in default namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Contributor

openshift-bot commented Apr 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments

Contributor

openshift-bot commented Apr 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 24, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-merge-robot merged commit f2c97bf into openshift:master

Contributor

openshift-ci-robot commented Apr 24, 2020

@dougbtv: All pull requests linked via external trackers have merged: openshift/multus-cni#60. Bugzilla bug 1827377 has been moved to the MODIFIED state.

In response to this:

Bug 1827377: Allows allow pods in any namespace refer to net-attach-defs in default namespace

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment