New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1900835: Multus should exit zero on DEL when cache file is missing and pod cannot be found. #82
Bug 1900835: Multus should exit zero on DEL when cache file is missing and pod cannot be found. #82
Conversation
@dougbtv: This pull request references Bugzilla bug 1900835, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…not be found. Otherwise, this can cause a pod to not be fully deleted, its sandbox may remain as the DEL continues to be retried due to exiting non-zero every time. See: https://bugzilla.redhat.com/show_bug.cgi?id=1900835
c5a503f
to
42d5484
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dougbtv, s1061123 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest
…On Thu, Dec 3, 2020, 1:57 PM OpenShift Merge Robot ***@***.***> wrote:
@dougbtv <https://github.com/dougbtv>: The following test *failed*, say
/retest to rerun all failed tests:
Test name Commit Details Rerun command
ci/prow/e2e-aws 42d5484
<42d5484>
link
<https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_multus-cni/82/pull-ci-openshift-multus-cni-master-e2e-aws/1334567635718770688> /test
e2e-aws
Full PR test history
<https://prow.ci.openshift.org/pr-history?org=openshift&repo=multus-cni&pr=82>.
Your PR dashboard
<https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:dougbtv>.
Instructions for interacting with me using PR comments are available here
<https://git.k8s.io/community/contributors/guide/pull-requests.md>. If
you have questions or suggestions related to my behavior, please file an
issue against the kubernetes/test-infra
<https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:>
repository. I understand the commands that are listed here
<https://go.k8s.io/bot-commands>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#82 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJX7PKLRK4OP5BIWVKPI3TSS7NRBANCNFSM4UBH4LVQ>
.
|
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@dougbtv: All pull requests linked via external trackers have merged: Bugzilla bug 1900835 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Otherwise, this can cause a pod to not be fully deleted, its sandbox may remain as the DEL continues to be retried due to exiting non-zero every time.