Bug 1927896: make a copy of global RuntimeConfig on merge #91

dougbtv · 2021-03-17T19:27:42Z

When we call mergeRuntimeConfig, the global RuntimeConfig gets
overwritten with the result of the merging, thus affecting the
subsequent delegates.

Do not modify the global RuntimeConfig and instead make a copy
when merging it.

Also, if a value has been provided for CNIDeviceInfoFile in the
delegate's runtimeconfig, overwrite it to avoid possible name
colissions.

Signed-off-by: Adrian Moreno amorenoz@redhat.com

When we call mergeRuntimeConfig, the global RuntimeConfig gets overwritten with the result of the merging, thus affecting the subsequent delegates. Do not modify the global RuntimeConfig and instead make a copy when merging it. Also, if a value has been provided for CNIDeviceInfoFile in the delegate's runtimeconfig, overwrite it to avoid possible name colissions. Signed-off-by: Adrian Moreno <amorenoz@redhat.com>

openshift-ci-robot · 2021-03-17T19:27:47Z

@dougbtv: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

s1061123 · 2021-03-17T20:07:32Z

/lgtm

Thank you for the backport!

Billy99

/lgtm

openshift-ci-robot · 2021-03-17T20:20:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Billy99, dougbtv, s1061123

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [dougbtv,s1061123]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2021-03-18T01:01:10Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-18T01:01:14Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-19T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-19T01:01:10Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-20T01:00:43Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-20T01:00:46Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-21T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-21T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-22T01:01:38Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-22T01:01:42Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-23T01:00:40Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-23T01:00:43Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-24T01:00:27Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-24T01:00:35Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-25T01:00:58Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-25T01:01:02Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-26T01:00:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-26T01:00:23Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-27T01:00:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-27T01:00:22Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-28T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-28T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-29T01:01:04Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-29T01:01:08Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-30T01:00:21Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-30T01:00:25Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-03-31T01:00:54Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-03-31T01:00:58Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-01T01:00:59Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-01T01:01:05Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-02T01:00:41Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-02T01:00:45Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is invalid:

expected dependent Bugzilla bug 1927895 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-03T01:01:18Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-03T01:01:25Z

@openshift-bot: This pull request references Bugzilla bug 1927896, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.z) matches configured target release for branch (4.7.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1927895 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1927895 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (weliang@redhat.com), skipping review request.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-10T18:40:25Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-04-10T18:53:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2021-04-10T20:00:23Z

@dougbtv: All pull requests linked via external trackers have merged:

openshift/multus-cni#91

Bugzilla bug 1927896 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Mar 17, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 17, 2021

dougbtv requested a review from Billy99 March 17, 2021 19:27

openshift-ci-robot requested review from fepan and squeed March 17, 2021 19:27

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2021

openshift-ci-robot assigned s1061123 Mar 17, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2021

Billy99 approved these changes Mar 17, 2021

View reviewed changes

openshift-ci-robot assigned Billy99 Mar 17, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 3, 2021

russellb added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 9, 2021

openshift-merge-robot merged commit 5530094 into openshift:release-4.7 Apr 10, 2021

Bug 1927896: make a copy of global RuntimeConfig on merge #91

Bug 1927896: make a copy of global RuntimeConfig on merge #91

Conversation

dougbtv commented Mar 17, 2021

openshift-ci-robot commented Mar 17, 2021

s1061123 commented Mar 17, 2021

Billy99 left a comment

Choose a reason for hiding this comment

openshift-ci-robot commented Mar 17, 2021

openshift-bot commented Mar 18, 2021

openshift-ci-robot commented Mar 18, 2021

openshift-bot commented Mar 19, 2021

openshift-ci-robot commented Mar 19, 2021

openshift-bot commented Mar 20, 2021

openshift-ci-robot commented Mar 20, 2021

openshift-bot commented Mar 21, 2021

openshift-ci-robot commented Mar 21, 2021

openshift-bot commented Mar 22, 2021

openshift-ci-robot commented Mar 22, 2021

openshift-bot commented Mar 23, 2021

openshift-ci-robot commented Mar 23, 2021

openshift-bot commented Mar 24, 2021

openshift-ci-robot commented Mar 24, 2021

openshift-bot commented Mar 25, 2021

openshift-ci-robot commented Mar 25, 2021

openshift-bot commented Mar 26, 2021

openshift-ci-robot commented Mar 26, 2021

openshift-bot commented Mar 27, 2021

openshift-ci-robot commented Mar 27, 2021

openshift-bot commented Mar 28, 2021

openshift-ci-robot commented Mar 28, 2021

openshift-bot commented Mar 29, 2021

openshift-ci-robot commented Mar 29, 2021

openshift-bot commented Mar 30, 2021

openshift-ci-robot commented Mar 30, 2021

openshift-bot commented Mar 31, 2021

openshift-ci-robot commented Mar 31, 2021

openshift-bot commented Apr 1, 2021

openshift-ci-robot commented Apr 1, 2021

openshift-bot commented Apr 2, 2021

openshift-ci-robot commented Apr 2, 2021

openshift-bot commented Apr 3, 2021

openshift-ci-robot commented Apr 3, 2021

openshift-bot commented Apr 10, 2021

openshift-bot commented Apr 10, 2021

openshift-ci-robot commented Apr 10, 2021