Skip to content

Commit

Permalink
Use oc get daemonset to identify the NTO image
Browse files Browse the repository at this point in the history
The previous method of using oc adm release info has been
problematic for CI and restricted network environment clusters.

The issue was always the authentication to the registry
and access to the release image from the inside of must-gather.

Also the oc adm release info tool runs inside a container and
does not respect the node level ImageContentSourcePolicy.

For all these reasons I want to retrieve the image name
from the configured NTO deployment instead.

Signed-off-by: Martin Sivak <msivak@redhat.com>
  • Loading branch information
MarSik committed Sep 4, 2023
1 parent a1352bc commit ae20e55
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion collection-scripts/gather_ppc
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ function ppc_nodes() {

# Find the NTO image reference
# NTO contains all the tools needed here
NTO=$(oc adm release info --image-for=cluster-node-tuning-operator)
NTO=$(oc get deployment -n openshift-cluster-node-tuning-operator cluster-node-tuning-operator -o jsonpath="{.spec.template.spec.containers[0].image}")
if [ $? -ne 0 ]; then
echo "ERROR: Failed to identify the container image with node tools."
echo "INFO: Node performance data collection will not contain node level data."
Expand Down

0 comments on commit ae20e55

Please sign in to comment.