Bug 1741685: collection-scripts: gather monitoring related resources #126
Conversation
|
@paulfantom: This pull request references Bugzilla bug 1741685, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/invalid-bug
paulfantom
force-pushed
the
gather_monitoring
branch
2 times, most recently
from
301ec3b
to
078f0fa
Compare
openshift-ci-robot
added
size/S
|
/cc @s-urbaniak |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: paulfantom, s-urbaniak The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@paulfantom: This pull request references Bugzilla bug 1741685, which is valid. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| # we use nested loops to nicely output objects partitioned per namespace, kind | ||
| for resource in ${resources[@]}; do | ||
| echo "INFO: Gathering ServiceMonitors in ${resource} namespace" | ||
| /usr/bin/oc get "${target}.servicemonitors.monitoring.coreos.com" -n "${resource}" -o yaml > "${BASE_COLLECTION_PATH}/${target}/${resource}.yaml" |
There was a problem hiding this comment.
Should we be collecting this with a related resource?
There was a problem hiding this comment.
This is almost impossible to gather with related resource right now as related resource would need to be implemented in every operator managing namespace in which ServiceMonitor is deployed.
I agree that related resource would be the best approach. It is just not feasible now.
There was a problem hiding this comment.
I still think we should push this to related resource across this operators over a script like this.
@deads2k do you agree?
There was a problem hiding this comment.
@sferich888 agreed, we'll implement related resources with respect to service monitors deployed in the openshift-monitoring namespace only. Please note that service monitors deployed by other operators are not going to be covered and must be implemented in their corresponding operator code.
We'll close this one out in favor of a PR against cluster-monitoring-operator setting those related fields for its own assets.
…hift-* namespaces
paulfantom
force-pushed
the
gather_monitoring
branch
from
078f0fa
to
473f3b7
Compare
|
New changes are detected. LGTM label has been removed. |
|
/close |
|
@paulfantom: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Add script to gather ServiceMonitors and PrometheusRules from multiple
openshift-*namespaces managed by multiple operators.