Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1849244: [release-4.5]Trace ovn processing in cluster #160

Merged
merged 2 commits into from Aug 1, 2020

Conversation

pecameron
Copy link
Contributor

@pecameron pecameron commented Jun 19, 2020

Backport #156 and #159 to release-4.5


PR 159 - Extract trace of ovn bringup

Scan through the generated trace for key lines in ovn bringup and report them.

SDN-1028 - Trace: generate trace of networking bring up
Trace: generate trace of networking bring up


PR 156 - Generate trace of ovn operation

This processes log files for namespace openshift-ovn-kubernetes.
It also captures the master and worker journals for kublet and crio.
It:

  • formats time stamps into a common format
  • adds a prefix to each log line consisting of:
  • time stamp
  • node name
  • pod name
  • container name

Extracts the log and previous log for each continer

  • applies the prefix to each line
  • combines all resulting files and
  • sorts the results into the trace
  • deletes work files.

SDN-975 - Logging: add must-gather networking-gather-trace script
https://issues.redhat.com/browse/SDN-975

Signed-off-by: Phil Cameron pcameron@redhat.com

Backport openshift#156 to
release-4.5

--------------
This processes log files for namespace openshift-ovn-kubernetes.
It also captures the master and worker journals for kublet and crio.
It:

- formats time stamps into a common format
- adds a prefix to each log line consisting of:
- time stamp
- node name
- pod name
- container name

Extracts the log and previous log for each continer
- applies the prefix to each line
- combines all resulting files and
- sorts the results into the trace
- deletes work files.

SDN-975 - Logging: add must-gather networking-gather-trace script
https://issues.redhat.com/browse/SDN-975

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@openshift-ci-robot
Copy link

@pecameron: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

Trace ovn processing in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@pecameron: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.5]Trace ovn processing in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron pecameron changed the title Trace ovn processing in cluster [release-4.5]Trace ovn processing in cluster Jun 19, 2020
@pecameron pecameron changed the title [release-4.5]Trace ovn processing in cluster Bug 1849244: [release-4.5]Trace ovn processing in cluster Jun 19, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Jun 19, 2020
@openshift-ci-robot
Copy link

@pecameron: This pull request references Bugzilla bug 1849244, which is invalid:

  • expected dependent Bugzilla bug 1849243 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1849244: [release-4.5]Trace ovn processing in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Jun 19, 2020
@pecameron
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@pecameron: This pull request references Bugzilla bug 1849244, which is invalid:

  • expected dependent Bugzilla bug 1849243 to target a release in 4.6.0, 4.6.z, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 19, 2020
@openshift-ci-robot
Copy link

@pecameron: This pull request references Bugzilla bug 1849244, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1849243 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1849243 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron
Copy link
Contributor Author

@dcbw PTAL
need this and (TDB) backport 4.4 to get openshift/release#8654 to work. CI is a 4.4 cluster.

@dcbw
Copy link
Member

dcbw commented Jun 24, 2020

/approve
/lgtm
/retest
(looks like an AWS setup issue, not due to this PR)

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 24, 2020
@pecameron
Copy link
Contributor Author

@dcbw what does it take to move this forward?

@pecameron
Copy link
Contributor Author

/assign @sferich888

@sferich888
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@pecameron
Copy link
Contributor Author

@sferich888 any idea when this will merge?

@sferich888
Copy link
Contributor

When tests pass.

Scan through the generated trace for key lines in ovn bringup and report
them.

SDN-1028 - Trace: generate trace of networking bring up
Trace: generate trace of networking bring up

Signed-off-by: Phil Cameron <pcameron@redhat.com>
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. and removed lgtm Indicates that a PR is ready to be merged. bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 10, 2020
@openshift-ci-robot
Copy link

@pecameron: This pull request references Bugzilla bug 1849244, which is invalid:

  • expected dependent Bugzilla bug 1849243 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (WORKSFORME) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1849244: [release-4.5]Trace ovn processing in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron
Copy link
Contributor Author

@dcbw PTAL
@sferich888 PTAL
I added PR159 which generates and additional report on network bringup

@pecameron
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@pecameron: This pull request references Bugzilla bug 1849244, which is invalid:

  • expected dependent Bugzilla bug 1849243 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is CLOSED (WORKSFORME) instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jul 10, 2020
@openshift-ci-robot
Copy link

@pecameron: This pull request references Bugzilla bug 1849244, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.z) matches configured target release for branch (4.5.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1849243 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1849243 targets the "4.6.0" release, which is one of the valid target releases: 4.6.0, 4.6.z
  • bug has dependents

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pecameron
Copy link
Contributor Author

@sferich888 @dcbw do you know who can cherry-pick approve this? It adds trace support for 4.5 clusters including the ci cluster. This permits a trace to be generated as part of ci artifacts. This change is a new script added to gather_network_ovn_trace which is not referenced by anything currently in 4.5. There is another PR in release to that is blocked waiting for this. This is a no risk change.

@dcbw
Copy link
Member

dcbw commented Jul 30, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dcbw, pecameron, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdodson
Copy link
Member

sdodson commented Jul 31, 2020

do you know who can cherry-pick approve this?

That's always the patch manager, that process never varies.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 31, 2020
@sdodson
Copy link
Member

sdodson commented Aug 1, 2020

/retest

@openshift-merge-robot openshift-merge-robot merged commit 4e97dec into openshift:release-4.5 Aug 1, 2020
@openshift-ci-robot
Copy link

@pecameron: All pull requests linked via external trackers have merged: openshift/must-gather#160. Bugzilla bug 1849244 has been moved to the MODIFIED state.

In response to this:

Bug 1849244: [release-4.5]Trace ovn processing in cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants