Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit: error out with audit profile None #246

Merged
merged 1 commit into from Jul 14, 2021
Merged

audit: error out with audit profile None #246

merged 1 commit into from Jul 14, 2021

Conversation

sttts
Copy link
Contributor

@sttts sttts commented Jun 30, 2021

@sttts
Copy link
Contributor Author

sttts commented Jun 30, 2021

/assign @EmilyM1 @Anandnatraj @soltysh

@sttts sttts force-pushed the sttts-audit-policy-profile-none branch from 3704a33 to 661b219 Compare June 30, 2021 12:32
soltysh
soltysh approved these changes Jun 30, 2021
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@sttts
Copy link
Contributor Author

sttts commented Jun 30, 2021

How can this be tested? Is it automatically used in e2e-aws?

@sttts
Copy link
Contributor Author

sttts commented Jul 4, 2021

/assign @sferich888

@sferich888
Copy link
Contributor

/lgtm

As this is simply adding logs/warning to an script that is not run by default.

How can this be tested? Is it automatically used in e2e-aws?

We would need to put tests into the CI system (for this); This repo doesn't necessarily have a good way to test situations like this. cc: @deads2k

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 14, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sferich888, soltysh, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 14, 2021
@openshift-merge-robot openshift-merge-robot merged commit edeb226 into openshift:master Jul 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@davemulford davemulford Awaiting requested review from davemulford

@RickJWagner RickJWagner Awaiting requested review from RickJWagner

Assignees

@soltysh soltysh

@sferich888 sferich888

@Anandnatraj Anandnatraj

@EmilyM1 EmilyM1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@sttts @sferich888 @soltysh @Anandnatraj @EmilyM1 @openshift-merge-robot