Bug 2039382: Add +x permission to gather_metallb_logs

[liornoy]

Execution permission was missing causing "Permission denied" error

[openshift-ci]

Hi @liornoy. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgoncalves]

LGTM

[liornoy]

@sferich888 Please note that the script gather_insights is also without execution permissions. is it a bug? do you want me to file a fix for it as well?

[RickJWagner]

Strange looking PR. (The text reads 'Empty file', so I checked to be certain there really were some contents in /gather_metallb_logs.) I see the icon indicating the change from 644->755, looks good.

[cgoncalves]

@sferich888 could you please help in reviewing and approving this PR? Thank you!

[sferich888]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liornoy, RickJWagner, sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• collection-scripts/OWNERS [RickJWagner,sferich888]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[cgoncalves]

Thanks, @sferich888!
It seems we still need the bugzilla/valid-bug label in order to complete all the checks and merge. Anything I can do to help (Lior is out of office)?

[sferich888]

/ok-to-test

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest-required

Please review the full test history for this PR and help us cut down flakes.

[cgoncalves]

/retitle Bug 2039382: Add +x permission to gather_metallb_logs

[openshift-ci]

@liornoy: This pull request references Bugzilla bug 2039382, which is invalid:

• expected the bug to target the "4.10.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 2039382: Add +x permission to gather_metallb_logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[cgoncalves]

/bugzilla refresh

[openshift-ci]

@cgoncalves: This pull request references Bugzilla bug 2039382, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target release (4.10.0) matches configured target release for branch (4.10.0)
• bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @zhouying7780

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

@liornoy: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-ci]

@liornoy: All pull requests linked via external trackers have merged:

• openshift/must-gather#274

Bugzilla bug 2039382 has been moved to the MODIFIED state.

In response to this:

Bug 2039382: Add +x permission to gather_metallb_logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fedepaol]

/hold