Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 2103283: Add timeout to oc cp command to fix must-gather delays when routers are terminating #317

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Bug 2103283: Add timeout to oc cp command to fix must-gather delays when routers are terminating #317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion collection-scripts/gather_haproxy_config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ function gather_haproxy_config {
for IC in ${INGRESS_CONTROLLERS}; do
PODS=$(oc get pods -n openshift-ingress --no-headers -o custom-columns=":metadata.name" --selector ingresscontroller.operator.openshift.io/deployment-ingresscontroller="${IC}")
for POD in ${PODS}; do
oc cp openshift-ingress/"${POD}":/var/lib/haproxy/conf/haproxy.config "${HAPROXY_CONFIG_PATH}"/"${IC}"/"${POD}"/haproxy.config &
timeout -v 3m oc cp openshift-ingress/"${POD}":/var/lib/haproxy/conf/haproxy.config "${HAPROXY_CONFIG_PATH}"/"${IC}"/"${POD}"/haproxy.config &
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is a 3 min timeout really how long we want to wait with this?
This copy operation should be seconds; IE 10x (seconds) is likely a 1-1.5 m wait time (can we half this)?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://coreos.slack.com/archives/CFDM5CQMN/p1657143478060469?thread_ts=1656698903.916469&cid=CFDM5CQMN discussed this.

/lgtm

PIDS+=($!)
done
done
Expand Down