Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Running gather scripts in background #399

Merged

Conversation

OdedViner
Copy link
Contributor

@OdedViner OdedViner commented Jan 2, 2024

To save time when running the OCP MG, the collection scripts can be executed in parallel.

Process:
1.Collect script
2.Waiting on subprocesses to finish execution.

Tested on my cluster and we can save 20% run time:

oviner:my_image$ time oc adm must-gather --image=quay.io/oviner/ocs-must-gather:ocp_mg2
real    7m49.209s
user    0m13.960s
sys     0m4.095s



oviner:regular_image$ time oc adm must-gather --image=quay.io/openshift/origin-must-gather:latest 
real	9m44.340s
user	0m14.055s
sys	0m4.115s

Signed-off-by: oviner <oviner@redhat.com>
@openshift-ci openshift-ci bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 2, 2024
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

Hi @OdedViner. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh
Copy link
Member

soltysh commented Jan 2, 2024

/ok-to-test

@openshift-ci openshift-ci bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 2, 2024
Signed-off-by: oviner <oviner@redhat.com>
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

@OdedViner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@soltysh soltysh changed the title Running gather scripts in background NO-JIRA: Running gather scripts in background Jan 2, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 2, 2024
@openshift-ci-robot
Copy link

@OdedViner: This pull request explicitly references no jira issue.

In response to this:

To save time when running the OCP MG, the collection scripts can be executed in parallel.

Process:
1.Collect script
2.Waiting on subprocesses to finish execution.

Tested on my cluster and we can save 20% run time:

oviner:my_image$ time oc adm must-gather --image=quay.io/oviner/ocs-must-gather:ocp_mg2
real    7m49.209s
user    0m13.960s
sys     0m4.095s



oviner:regular_image$ time oc adm must-gather --image=quay.io/openshift/origin-must-gather:latest 
real	9m44.340s
user	0m14.055s
sys	0m4.115s

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label tide/merge-method-squash
/lgtm
/approve

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jan 2, 2024
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 2, 2024
Copy link
Contributor

openshift-ci bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: OdedViner, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit 4c685e0 into openshift:master Jan 2, 2024
3 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-must-gather-container-v4.16.0-202401022050.p0.g4c685e0.assembly.stream for distgit ose-must-gather.
All builds following this will include this PR.

@sferich888
Copy link
Contributor

Does this affect any of the logging out tracing that are possible today using the trace files?

@OdedViner
Copy link
Contributor Author

Does this affect any of the logging out tracing that are possible today using the trace files?

Created private image quay.io/oviner/ocs-must-gather:ocp_mg2
I uploaded the mg dir https://url.corp.redhat.com/886dfba
Can yu check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants