Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoids to collect frr.log for MetalLB #427

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rh-fcristin
Copy link

Entire frr.log files collected by the gather_metallb can be huge in size (several GB) and in case of clusters with a lot of nodes the must-gather size can grow easily to an unreasonable size to be shared.
Part of the frr logs are already into the regular container logs, I believe that in case these logs are really needed for troubleshooting we can still ask for them.

I'm proposing here to remove the frr.log files collection from the gather_metallb script, this will drastically improve the size of the must-gather.

Entire frr.log files collected by the gather_metallb can be huge in size
(several GB) and in case of cluster with a lot of nodes the must-gather
size can grow easiliy to an unreasonable size.
This removes the collection of frr.logs files from the gather_metallb
script.
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rh-fcristin
Once this PR has been reviewed and has the lgtm label, please assign davemulford for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@RickJWagner RickJWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable.
Looks good to me.

Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

@rh-fcristin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants