threading mg execution and ensuring that we alway exit 0 (true)

[sferich888]

@RickJWagner @coreydaley PTAL
@sanchezl you may want to review as well.

[sferich888]

/hold

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sferich888

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• collection-scripts/OWNERS [sferich888]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[RickJWagner]

In 'gather', do we really want to make the same directory in a loop? It seems we'd make it once and have it.

for resource in ${resources[@]}; do
LOG_DIR="${BASE_COLLECTION_PATH}/must-gather-resource-logs"
mkdir -p ${LOG_DIR}

[sanchezl]

Suggested change

	/usr/bin/openshift-must-gather inspect ${resource} 2> ${LOG_DIR}/${resource/\//_}.log &
	/usr/bin/openshift-must-gather inspect ${resource} 2> ${LOG_DIR}/${resource//[^A-Za-z0-9._-]/_}.log &

[sferich888]

I don't understand the sugestion, my code converts resources with '/' in them like ns/default to resources names with '_' in them like ns_default, what is yours doing?

This avoid bash path issues when I go to save the resource.

[sferich888]

@sanchezl can you followup here?

[sferich888]

@RickJWagner I fixed the log directory creation, happening in a loop.

[openshift-ci-robot]

@sferich888: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws	e87e03e	link	/test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[sferich888]

Obsolete