Remove e2e tests that consistently fail in 4.13 #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In 4.13 deployment (e.g. gcp), metric container_network_receive_bytes_total has empty values for label namespace and pod, the value for label interface is changed to the first 15 bits of pod sandbox ID (br-int side pod interface with ovnk), which results in consistent failure in two tests (removed in this commit) e2e. Signed-off-by: Zenghui Shi <zshi@redhat.com>
openshift-ci
bot
added
the
approved
|
@zshi-redhat: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: s1061123, zshi-redhat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/revert |
SchSeba
added a commit
to SchSeba/network-metrics-daemon
that referenced
this pull request
Jun 11, 2023
This reverts commit 329da5e.
openshift-merge-robot
pushed a commit
that referenced
this pull request
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.13 deployment (e.g. gcp), metric container_network_receive_bytes_total has empty values for label namespace and pod, the value for label interface is changed to the first 15 bits of pod sandbox ID (br-int side pod interface with ovnk), which results in consistent failure in two tests (removed in this commit) e2e.