Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-21560: [4.13] Update the k8s dependencies to 1.26.10 #83

Merged
merged 1 commit into from Nov 10, 2023

Conversation

pliurh
Copy link
Contributor

@pliurh pliurh commented Oct 30, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 30, 2023
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Jira Issue OCPBUGS-21560, which is invalid:

  • expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "4.13.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Oct 30, 2023
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023
@pliurh pliurh changed the base branch from master to release-4.13 October 30, 2023 08:33
@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Jira Issue OCPBUGS-21560, which is invalid:

  • expected Jira Issue OCPBUGS-21560 to depend on a bug targeting a version in 4.14.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pliurh pliurh changed the title OCPBUGS-21560: Update the k8s dependencies to 1.26.10 OCPBUGS-21560: [4.13] Update the k8s dependencies to 1.26.10 Oct 30, 2023
@openshift-ci
Copy link

openshift-ci bot commented Oct 30, 2023

@pliurh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/images baa09ce link true /test images
ci/prow/unit baa09ce link true /test unit
ci/prow/e2e-gcp baa09ce link true /test e2e-gcp

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 30, 2023
@pliurh
Copy link
Contributor Author

pliurh commented Nov 9, 2023

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@pliurh: This pull request references Jira Issue OCPBUGS-21560, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pliurh
Copy link
Contributor Author

pliurh commented Nov 9, 2023

/cc @fedepaol

@openshift-ci openshift-ci bot requested a review from fedepaol November 9, 2023 06:40
@zshi-redhat
Copy link
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 10, 2023
@openshift-ci-robot
Copy link
Contributor

@zshi-redhat: This pull request references Jira Issue OCPBUGS-21560, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.13.z) matches configured target version for branch (4.13.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-21566 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-21566 targets the "4.14.z" version, which is one of the valid target versions: 4.14.0, 4.14.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (weliang@redhat.com), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 10, 2023
@zshi-redhat
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pliurh, zshi-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@openshift-merge-bot openshift-merge-bot bot merged commit ff460fb into openshift:release-4.13 Nov 10, 2023
4 checks passed
@openshift-ci-robot
Copy link
Contributor

@pliurh: Jira Issue OCPBUGS-21560: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21560 has been moved to the MODIFIED state.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zshi-redhat
Copy link
Contributor

@pliurh it looks like we don't have cherry-pick-approved and backport-risk-assessed labels enabled in this repo ?

@pliurh
Copy link
Contributor Author

pliurh commented Nov 10, 2023

@pliurh it looks like we don't have cherry-pick-approved and backport-risk-assessed labels enabled in this repo ?

I think we did https://github.com/openshift/release/blob/a65bd6cd2c144fc5e0471e3cbb3f121264038a65/core-services/prow/02_config/openshift/network-metrics-daemon/_pluginconfig.yaml#L16.

@zshi-redhat
Copy link
Contributor

zshi-redhat commented Nov 10, 2023

@pliurh it looks like we don't have cherry-pick-approved and backport-risk-assessed labels enabled in this repo ?

I think we did https://github.com/openshift/release/blob/a65bd6cd2c144fc5e0471e3cbb3f121264038a65/core-services/prow/02_config/openshift/network-metrics-daemon/_pluginconfig.yaml#L16.

It seems that's not sufficient, as the label is currently not required to merge PR to release branches.
Compared with what ovn-kubernetes does, we probably need to change both prowconfig.yaml and pluginconfig.yaml for network-metrics-daemon:
https://github.com/openshift/release/blob/a65bd6cd2c144fc5e0471e3cbb3f121264038a65/core-services/prow/02_config/openshift/ovn-kubernetes/_prowconfig.yaml#L33-L39
https://github.com/openshift/release/blob/a65bd6cd2c144fc5e0471e3cbb3f121264038a65/core-services/prow/02_config/openshift/ovn-kubernetes/_pluginconfig.yaml#L4-L9

@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-network-metrics-daemon-container-v4.13.0-202311211131.p0.gff460fb.assembly.stream for distgit ose-network-metrics-daemon.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants