Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-JIRA: Fix alphabetical ordering of packages in Dockerfiles #123

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

danwinship
Copy link
Contributor

had been part of #121 but that's probably not happening

/assign @npinaeva

(like the comments say)

Also deduplicate the two packages that are now obviously listed twice
in Dockerfile.fedora (iproute and perf).
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 10, 2024
@npinaeva
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 10, 2024
Copy link
Contributor

openshift-ci bot commented Apr 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, npinaeva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danwinship,npinaeva]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@npinaeva
Copy link
Member

/retitle NO-JIRA: Fix alphabetical ordering of packages in Dockerfiles

@openshift-ci openshift-ci bot changed the title Fix alphabetical ordering of packages in Dockerfiles NO-JIRA: Fix alphabetical ordering of packages in Dockerfiles Apr 11, 2024
@openshift-bot openshift-bot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2024
@openshift-bot
Copy link

@danwinship: This pull request explicitly references no jira issue.

In response to this:

had been part of #121 but that's probably not happening

/assign @npinaeva

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@npinaeva
Copy link
Member

/retest

Copy link
Contributor

openshift-ci bot commented Apr 11, 2024

@danwinship: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 0e1891d into openshift:master Apr 11, 2024
3 checks passed
@danwinship danwinship deleted the alphabetize branch April 11, 2024 13:16
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-network-tools-container-v4.16.0-202404120544.p0.g0e1891d.assembly.stream.el8 for distgit ose-network-tools.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants