Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

split tests and do containerized tests #19

Merged
merged 1 commit into from Dec 4, 2020
Merged

split tests and do containerized tests #19

merged 1 commit into from Dec 4, 2020

Conversation

juanluisvaladas
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 1, 2020
@juanluisvaladas juanluisvaladas changed the title [WIP] split tests and do containerized tests split tests and do containerized tests Dec 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 1, 2020
@juanluisvaladas
Copy link
Contributor Author

/retest

1 similar comment
@juanluisvaladas
Copy link
Contributor Author

/retest

@rcarrillocruz
Copy link
Contributor

/approve

@juanluisvaladas
Copy link
Contributor Author

/retest

@tssurya
Copy link
Contributor

tssurya commented Dec 4, 2020

/lgtm
I haven't tested it against a cluster, but the basic functionality looks ok to me for the test_sdn script.

note: we still need to refactor the scripts; so the code in the common directory is not final , but we'll do that after the ff.
@juanluisvaladas : please make sure to add instructions to run your script later on (I think Andrew agreed to do the README )

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 4, 2020
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juanluisvaladas, rcarrillocruz, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [juanluisvaladas,rcarrillocruz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit e9a1e3d into openshift:master Dec 4, 2020
@tssurya
Copy link
Contributor

tssurya commented Dec 4, 2020

Also as discussed with Juan we currently cope all files without maintaining the directory structure into /usr/bin:

https://github.com/openshift/debug-network/blob/master/Dockerfile#L7

This means in the image the ovn/pod_to_pod.sh will get overwritten by common/pod_to_pod.sh or vice versa.

we need to fix the naming and/or fix where we load the files in the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhat abhat Awaiting requested review from abhat

@s1061123 s1061123 Awaiting requested review from s1061123

Assignees

@tssurya tssurya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@juanluisvaladas @rcarrillocruz @tssurya @openshift-ci-robot @openshift-merge-robot