Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating ose-network-tools builder & base images to be consistent with ART #25

Closed
wants to merge 1 commit into from
Closed

Updating ose-network-tools builder & base images to be consistent with ART #25

wants to merge 1 commit into from

Conversation

openshift-bot
Copy link

Updating ose-network-tools builder & base images to be consistent with ART
Reconciling with https://github.com/openshift/ocp-build-data/tree/b0ab44b419faae6b18e639e780a1fa50a1df8521/images/ose-network-tools.yml

If you have any questions about this pull request, please reach out to @art-team in the #aos-art coreos slack channel.

@squeed
Copy link

squeed commented Jan 13, 2021

/assign @rcarrillocruz
/uncc

@tssurya
Copy link
Contributor

tssurya commented Jan 15, 2021

/test e2e-aws

@tssurya
Copy link
Contributor

tssurya commented Jan 15, 2021

/lgtm

The change seems ok, but CI is not passing. So we have to hold this.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 15, 2021
@danwinship
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@danielmellado
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, danwinship, openshift-bot, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@tssurya
Copy link
Contributor

tssurya commented Jan 18, 2021

Erm, how do I fix a merge conflict for a bot PR ?

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Author

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jan 19, 2021

@openshift-bot: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws ebeddd1 link /test e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Contributor

@openshift-bot: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 19, 2021
@tssurya
Copy link
Contributor

tssurya commented Jan 19, 2021

/close

Since there is a merge-conflict and I don't know if I have access to the bot's branch, I'll close this PR in favour of #28 where I fix the svc.ci to ci

@openshift-ci-robot
Copy link
Contributor

@tssurya: Closed this PR.

In response to this:

/close

Since there is a merge-conflict and I don't know if I have access to the bot's branch, I'll close this PR in favour of #28 where I fix the svc.ci to ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants