SDN-1521: oc-plumbing-related-refactoring #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/hold until #24 merges. |
openshift-ci-robot
added
do-not-merge/hold
tssurya
force-pushed
the
oc-plumbing-related-refactor
branch
from
ffa9e6b
to
5fdd314
Compare
openshift-ci-robot
removed
the
needs-rebase
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
tssurya
changed the title
tssurya
force-pushed
the
oc-plumbing-related-refactor
branch
from
5fdd314
to
5ba6d7f
Compare
|
/assign @juanluisvaladas @rcarrillocruz @astoycos |
juanluisvaladas
suggested changes
Jan 29, 2021
tssurya
force-pushed
the
oc-plumbing-related-refactor
branch
from
5ba6d7f
to
2abf996
Compare
thanks Juan for the review. Have addressed the nits. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanluisvaladas, tssurya The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Though the change looks big, its not:
I've refactored the folder structure under debug-scripts since in the image all scripts get copied into /usr/bin without retaining their folder structure. In future when we have more files, we can start using folders for arrangement.
I've removed the
versionanddebugfiles since they don't seem really necessary.I've moved some common functions into
common.Added the integration script for oc plumbing
network-toolsSDN scripts were not working. Tidied them up and made them similar to OVN scripts.
TODOs after getting the client plumbing merged on the oc side:
sdn_cluster_connectivityandsriov_connectivityscripts./cc @rcarrillocruz @juanluisvaladas : PTAL.
@astoycos : I've also modified your script moving the pod creation portions to a more common place. You can also push a PR later on to change the rest of the script accordingly and remove the comment of the script from the
network-toolscall.Advise to reviewers: Go commit by commit than going through all the files. It will be easier to reivew.