Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-1492: Delete .rhel7 dockerfile #27

Merged
merged 1 commit into from Jan 19, 2021

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Jan 18, 2021

Now that we have merged openshift/release#14990
and openshift-eng/ocp-build-data#808 we can go
ahead and remove the .rhel7 file.

As agreed on #24 , let's remove the extra Dockerfile and keep it clean.

/assign @danielmellado and @juanluisvaladas

Now that we have merged openshift/release#14990
and openshift-eng/ocp-build-data#808 we can go
ahead and remove the .rhel7 file.
@openshift-ci-robot
Copy link
Contributor

@tssurya: GitHub didn't allow me to assign the following users: and.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Now that we have merged openshift/release#14990
and openshift-eng/ocp-build-data#808 we can go
ahead and remove the .rhel7 file.

As agreed on #24 , let's remove the extra Dockerfile and keep it clean.

/assign @danielmellado and @juanluisvaladas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya
Copy link
Contributor Author

tssurya commented Jan 18, 2021

/hold

till openshift/release#14990 merges.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2021
@juanluisvaladas
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2021
@tssurya
Copy link
Contributor Author

tssurya commented Jan 18, 2021

/hold cancel
/test e2e-aws

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 18, 2021
@danielmellado
Copy link

/approve

@danielmellado
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 19, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, juanluisvaladas, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,juanluisvaladas]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 123583d into openshift:master Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants