Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDN-1567: Add User and Contributor Docs #31

Merged
merged 1 commit into from Feb 1, 2021

Conversation

tssurya
Copy link
Contributor

@tssurya tssurya commented Jan 29, 2021

  • Contributor docs: Adds a minimum set of instructions for writing scripts
  • User docs: Maintain information about each script.

Note that the user-docs need to be updated once we get the oc adm network-tools patch in. The initial documentation is being pushed to satisfy the security review.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2021
@tssurya tssurya changed the title [WIP] Add User and Contributor Docs SDN 1360: [WIP] Add User and Contributor Docs Jan 29, 2021
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 29, 2021
@tssurya tssurya changed the title SDN 1360: [WIP] Add User and Contributor Docs SDN 1567: [WIP] Add User and Contributor Docs Jan 29, 2021
@tssurya tssurya changed the title SDN 1567: [WIP] Add User and Contributor Docs SDN-1567: [WIP] Add User and Contributor Docs Jan 29, 2021
Also updates the README section to point to the docs.`
@tssurya tssurya changed the title SDN-1567: [WIP] Add User and Contributor Docs SDN-1567: Add User and Contributor Docs Jan 29, 2021
@tssurya
Copy link
Contributor Author

tssurya commented Jan 29, 2021

/assign @rcarrillocruz and @danielmellado

@openshift-ci-robot
Copy link
Contributor

@tssurya: GitHub didn't allow me to assign the following users: and.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @rcarrillocruz and @danielmellado

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tssurya
Copy link
Contributor Author

tssurya commented Jan 31, 2021

/test e2e-aws

@rcarrillocruz
Copy link
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 1, 2021
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rcarrillocruz, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2021
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 3dc1065 into openshift:master Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants