Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contrack and perf to network-tools #32

Merged
merged 1 commit into from Feb 23, 2021
Merged

Add contrack and perf to network-tools #32

merged 1 commit into from Feb 23, 2021

Conversation

rcarrillocruz
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2021
@danielmellado
Copy link

danielmellado commented Feb 2, 2021 •
edited

Pretty straightforward, Iet's get this in, the CI issues seems unrelated to the patch

@danielmellado
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 2, 2021
@tssurya
Copy link
Contributor

tssurya commented Feb 2, 2021

/retest

@rcarrillocruz
Copy link
Contributor Author

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2021
@rcarrillocruz
Copy link
Contributor Author

/cancel hold per @tssurya

@tssurya
Copy link
Contributor

tssurya commented Feb 23, 2021

/lgtm

Next time we do a refactor, let's get the naming in the Dockerfile for the packages alphabetical for sanity, else it would get harder to see what is installed and what is not, when they increase in number.
I don't want to stop this merge just for that.

@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielmellado, rcarrillocruz, tssurya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [danielmellado,rcarrillocruz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tssurya
Copy link
Contributor

tssurya commented Feb 23, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2021
@openshift-merge-robot openshift-merge-robot merged commit cfe245d into openshift:master Feb 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmellado danielmellado Awaiting requested review from danielmellado

@tssurya tssurya Awaiting requested review from tssurya

Assignees

@danielmellado danielmellado

@tssurya tssurya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@rcarrillocruz @danielmellado @tssurya @openshift-ci-robot @openshift-merge-robot